From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA850C433DB for ; Tue, 26 Jan 2021 13:45:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BA8A229C9 for ; Tue, 26 Jan 2021 13:45:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391856AbhAZNop (ORCPT ); Tue, 26 Jan 2021 08:44:45 -0500 Received: from mga01.intel.com ([192.55.52.88]:33260 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405243AbhAZNol (ORCPT ); Tue, 26 Jan 2021 08:44:41 -0500 IronPort-SDR: nyj/eVyxZKECFe1XJ8NkTsOk6EE/NnRv2h7b7Vt9alCvOP7x1RZ8KM0G/fCZIQY+DD+8rhDm8u F3nhqmq3COMw== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="198689176" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="198689176" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 05:42:54 -0800 IronPort-SDR: z5HKJiY8UqzEy591AFqdOKmfurt0K0FiY4UyqrhraP4QPIWXdbbJXqlZ+agW+raRY9ZgYyel4I vDaZtVL0XwbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="356726394" Received: from marshy.an.intel.com (HELO [10.122.105.143]) ([10.122.105.143]) by orsmga006.jf.intel.com with ESMTP; 26 Jan 2021 05:42:54 -0800 Subject: Re: [PATCHv3 4/6] fpga: of-fpga-region: add authenticate-fpga-config property To: Moritz Fischer Cc: trix@redhat.com, gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, dinguyen@kernel.org, sridhar.rajagopal@intel.com, Richard Gong References: <1611608188-25621-1-git-send-email-richard.gong@linux.intel.com> <1611608188-25621-5-git-send-email-richard.gong@linux.intel.com> From: Richard Gong Message-ID: Date: Tue, 26 Jan 2021 08:03:40 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Hi Moritz, On 1/25/21 11:10 PM, Moritz Fischer wrote: > On Mon, Jan 25, 2021 at 02:56:26PM -0600, richard.gong@linux.intel.com wrote: >> From: Richard Gong >> >> Add authenticate-fpga-config property to support FPGA bitstream >> authentication, which makes sure a signed bitstream has valid signatures. >> >> Signed-off-by: Richard Gong >> --- >> v3: no change >> v2: changed in alphabetical order >> --- >> drivers/fpga/of-fpga-region.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c >> index e405309..3840883 100644 >> --- a/drivers/fpga/of-fpga-region.c >> +++ b/drivers/fpga/of-fpga-region.c >> @@ -219,6 +219,9 @@ static struct fpga_image_info *of_fpga_region_parse_ov( >> info->overlay = overlay; >> >> /* Read FPGA region properties from the overlay */ >> + if (of_property_read_bool(overlay, "authenticate-fpga-config")) >> + info->flags |= FPGA_MGR_BITSTREM_AUTHENTICATION; >> + > Should you check here that no new nodes are being added as you *only* > authenticate? Sure, I will add additional checks in next submission. > >> if (of_property_read_bool(overlay, "partial-fpga-config")) >> info->flags |= FPGA_MGR_PARTIAL_RECONFIG; >> >> -- >> 2.7.4 >> > > Thanks, > Moritz > Regards, Richard