From: Tom Rix <trix@redhat.com>
To: Richard Gong <richard.gong@linux.intel.com>,
mdf@kernel.org, linux-fpga@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: dinguyen@kernel.org, sridhar.rajagopal@intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property
Date: Sat, 14 Nov 2020 07:59:37 -0800 [thread overview]
Message-ID: <a63cb1f6-4bb4-9f7d-e1b0-8054e8d4a21b@redhat.com> (raw)
In-Reply-To: <e7b815c1-e153-2bed-7793-0affd4d74f9e@linux.intel.com>
On 11/14/20 6:52 AM, Richard Gong wrote:
> Hi Tom,
>
>>> prior to OS boot up.
>>> - encrypted-fpga-config : boolean, set if the bitstream is encrypted
>>> +- authenticate-fpga-config : boolean, set if do bitstream authentication
>>
>> The list is mostly in alphabetical order so the new 'authenticate-... ' should go at the top.
>>
>
> The original list is not in alphabetical order. The order of partial-fpga-config, external-fpga-config and encrypted-fpga-config here follows the implementation in the of-fpga-region.c file.
>
> So authenticate-fpga-config should follow the way, correct?
>
This is why i say 'mostly' ..
In general when listing options for a user to read, you should make it easy for them to find
the option they are looking for. Ordering them alphabetically is an obvious but not the only
way. I am not asking for you to fix the whole table, just what you are adding. If there is
a better way to organize them please propose the method.
Tom
>> Improve what you mean by 'authentication' similar to my comment in the first patch.
>>
>
> Will do in the version 2 submission.
>
> Regards,
> Richard
>
>> Tom
>>
>>> - region-unfreeze-timeout-us : The maximum time in microseconds to wait for
>>> bridges to successfully become enabled after the region has been
>>> programmed.
>>
>
next prev parent reply other threads:[~2020-11-14 16:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 18:06 [PATCHv1 0/4] Extend FPGA manager and region drivers for richard.gong
2020-11-12 18:06 ` [PATCHv1 1/4] fpga: fpga-mgr: add FPGA_MGR_BITSTREM_AUTHENTICATION flag richard.gong
2020-11-13 20:24 ` Tom Rix
2020-11-14 14:30 ` Richard Gong
2020-11-14 15:53 ` Tom Rix
2020-11-16 13:39 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 2/4] fpga: of-fpga-region: add authenticate-fpga-config property richard.gong
2020-11-13 20:25 ` Tom Rix
2020-11-12 18:06 ` [PATCHv1 3/4] dt-bindings: fpga: " richard.gong
2020-11-13 20:28 ` Tom Rix
2020-11-14 14:52 ` Richard Gong
2020-11-14 15:59 ` Tom Rix [this message]
2020-11-16 13:50 ` Richard Gong
2020-11-16 15:11 ` Tom Rix
2020-11-15 19:21 ` Moritz Fischer
2020-11-16 2:47 ` Xu Yilun
2020-11-16 14:14 ` Richard Gong
2020-11-17 2:24 ` Xu Yilun
2020-11-17 15:39 ` Richard Gong
2020-11-18 5:47 ` Xu Yilun
2020-11-18 13:38 ` Richard Gong
2020-11-19 11:14 ` Xu Yilun
2020-11-16 13:59 ` Richard Gong
2020-11-12 18:06 ` [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication richard.gong
2020-11-13 20:31 ` Tom Rix
2020-11-14 14:55 ` Richard Gong
2020-11-15 19:19 ` Moritz Fischer
2020-11-16 14:39 ` Richard Gong
2020-11-16 2:41 ` [PATCHv1 0/4] Extend FPGA manager and region drivers for Xu Yilun
2020-11-16 14:02 ` Richard Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a63cb1f6-4bb4-9f7d-e1b0-8054e8d4a21b@redhat.com \
--to=trix@redhat.com \
--cc=dinguyen@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=sridhar.rajagopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).