Re: [PATCH 5/5] fpga: m10bmc-sec: switch show_canceled_csk() to using sysfs_emit()

Xu Yilun
2026-03-24T09:36:29Z

On Tue, Mar 03, 2026 at 03:08:41PM -0500, Yury Norov wrote:
> Switch show_canceled_csk() to use the proper sysfs_emit("%*pbl").
>
> Reviewed-by: Russ Weight <russ.weight@linux.dev>
> Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
> Signed-off-by: Yury Norov <ynorov@nvidia.com>
> ---
> drivers/fpga/intel-m10-bmc-sec-update.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/intel-m10-bmc-sec-update.c b/drivers/fpga/intel-m10-bmc-sec-update.c
> index 10f678b9ed36..ae364c6636eb 100644
> --- a/drivers/fpga/intel-m10-bmc-sec-update.c
> +++ b/drivers/fpga/intel-m10-bmc-sec-update.c
> @@ -10,6 +10,7 @@
> #include <linux/firmware.h>
> #include <linux/mfd/intel-m10-bmc.h>
> #include <linux/mod_devicetable.h>
> +#include <linux/mm.h>

Why add this header file?

Thanks,
Yilun

> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> @@ -183,7 +184,7 @@ show_canceled_csk(struct device *dev, u32 addr, char *buf)
>
> bitmap_from_arr32(csk_map, csk32, CSK_BIT_LEN);
> bitmap_complement(csk_map, csk_map, CSK_BIT_LEN);
> - return bitmap_print_to_pagebuf(1, buf, csk_map, CSK_BIT_LEN);
> + return sysfs_emit(buf, "%*pbl\n", CSK_BIT_LEN, csk_map);
> }
>
> #define DEVICE_ATTR_SEC_CSK_RO(_name) \
> --
> 2.43.0
>
>