From: Xu Yilun <yilun.xu@linux.intel.com>
To: Wentao Liang <vulab@iscas.ac.cn>
Cc: Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] fpga: region: fix use-after-free in child_regions_with_firmware()
Date: Mon, 4 May 2026 19:22:20 +0800 [thread overview]
Message-ID: <afiBbC46CFauotNt@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20260408154534.404327-1-vulab@iscas.ac.cn>
On Wed, Apr 08, 2026 at 03:45:34PM +0000, Wentao Liang wrote:
> Move of_node_put(child_region) after the error print to avoid accessing
> freed memory when pr_err() references child_region.
>
> Fixes: ef3acdd82075 ("fpga: region: move device tree support to of-fpga-region.c")
The Fixes tag should identify the commit that introduced the problem, so
it should be:
Fixes: 0fa20cdfcc1f ("fpga: fpga-region: device tree control for FPGA")
I fixed it in place.
Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Applied to for-next
prev parent reply other threads:[~2026-05-04 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:45 [PATCH] fpga: region: fix use-after-free in child_regions_with_firmware() Wentao Liang
2026-05-04 11:22 ` Xu Yilun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afiBbC46CFauotNt@yilunxu-OptiPlex-7050 \
--to=yilun.xu@linux.intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=stable@vger.kernel.org \
--cc=trix@redhat.com \
--cc=vulab@iscas.ac.cn \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox