From: matthew.gerlach@linux.intel.com
To: Alan Tull <atull@kernel.org>
Cc: Moritz Fischer <mdf@kernel.org>,
linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
Subject: Re: [PATCH v4 17/18] fpga: clean up fpga Kconfig
Date: Thu, 14 Sep 2017 08:56:36 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1709140856110.2384@mgerlach-VirtualBox> (raw)
In-Reply-To: <20170913204841.2730-18-atull@kernel.org>
Hi Alan,
s/mixxed/mixed/
On Wed, 13 Sep 2017, Alan Tull wrote:
> The fpga menuconfig has gotten messy. The bridges and managers are
> mixxed together.
>
> * Separate the bridges and things dependent on CONFIG_FPGA_BRIDGE
> from the managers.
> * Group the managers by vendor in order that they were added
> to the kernel.
>
> The following is what the menuconfig ends up looking like more or less
> (platform dependencies are hiding some of these on any given
> platform).
>
> --- FPGA Configuration Framework
> <*> Altera SOCFPGA FPGA Manager
> <*> Altera SoCFPGA Arria10
> <*> Altera Partial Reconfiguration IP Core
> <*> Platform support of Altera Partial Reconfiguration IP Core
> <*> Altera FPGA Passive Serial over SPI
> <*> Altera Arria-V/Cyclone-V/Stratix-V CvP FPGA Manager
> <*> Xilinx Zynq FPGA
> <*> Xilinx Configuration over Slave Serial (SPI)
> <*> Lattice iCE40 SPI
> <*> Technologic Systems TS-73xx SBC FPGA Manager
> <*> FPGA Bridge Framework
> <*> Altera SoCFPGA FPGA Bridges
> <*> Altera FPGA Freeze Bridge
> <*> Xilinx LogiCORE PR Decoupler
> <*> FPGA Region
> <*> FPGA Region Device Tree Overlay Support
>
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
> v4: Patch added to patchset in v4
> ---
> drivers/fpga/Kconfig | 106 +++++++++++++++++++++++++--------------------------
> 1 file changed, 53 insertions(+), 53 deletions(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 529b729..231e948 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -11,32 +11,30 @@ menuconfig FPGA
>
> if FPGA
>
> -config FPGA_REGION
> - tristate "FPGA Region"
> - depends on FPGA_BRIDGE
> +config FPGA_MGR_SOCFPGA
> + tristate "Altera SOCFPGA FPGA Manager"
> + depends on ARCH_SOCFPGA || COMPILE_TEST
> help
> - FPGA Region common code. A FPGA Region controls a FPGA Manager
> - and the FPGA Bridges associated with either a reconfigurable
> - region of an FPGA or a whole FPGA.
> + FPGA manager driver support for Altera SOCFPGA.
>
> -config OF_FPGA_REGION
> - tristate "FPGA Region Device Tree Overlay Support"
> - depends on OF && FPGA_REGION
> +config FPGA_MGR_SOCFPGA_A10
> + tristate "Altera SoCFPGA Arria10"
> + depends on ARCH_SOCFPGA || COMPILE_TEST
> + select REGMAP_MMIO
> help
> - Support for loading FPGA images under control of Device Tree.
> + FPGA manager driver support for Altera Arria10 SoCFPGA.
>
> -config FPGA_MGR_ICE40_SPI
> - tristate "Lattice iCE40 SPI"
> - depends on OF && SPI
> - help
> - FPGA manager driver support for Lattice iCE40 FPGAs over SPI.
> +config ALTERA_PR_IP_CORE
> + tristate "Altera Partial Reconfiguration IP Core"
> + help
> + Core driver support for Altera Partial Reconfiguration IP component
>
> -config FPGA_MGR_ALTERA_CVP
> - tristate "Altera Arria-V/Cyclone-V/Stratix-V CvP FPGA Manager"
> - depends on PCI
> +config ALTERA_PR_IP_CORE_PLAT
> + tristate "Platform support of Altera Partial Reconfiguration IP Core"
> + depends on ALTERA_PR_IP_CORE && OF && HAS_IOMEM
> help
> - FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V
> - and Arria 10 Altera FPGAs using the CvP interface over PCIe.
> + Platform driver support for Altera Partial Reconfiguration IP
> + component
>
> config FPGA_MGR_ALTERA_PS_SPI
> tristate "Altera FPGA Passive Serial over SPI"
> @@ -45,25 +43,19 @@ config FPGA_MGR_ALTERA_PS_SPI
> FPGA manager driver support for Altera Arria/Cyclone/Stratix
> using the passive serial interface over SPI.
>
> -config FPGA_MGR_SOCFPGA
> - tristate "Altera SOCFPGA FPGA Manager"
> - depends on ARCH_SOCFPGA || COMPILE_TEST
> - help
> - FPGA manager driver support for Altera SOCFPGA.
> -
> -config FPGA_MGR_SOCFPGA_A10
> - tristate "Altera SoCFPGA Arria10"
> - depends on ARCH_SOCFPGA || COMPILE_TEST
> - select REGMAP_MMIO
> +config FPGA_MGR_ALTERA_CVP
> + tristate "Altera Arria-V/Cyclone-V/Stratix-V CvP FPGA Manager"
> + depends on PCI
> help
> - FPGA manager driver support for Altera Arria10 SoCFPGA.
> + FPGA manager driver support for Arria-V, Cyclone-V, Stratix-V
> + and Arria 10 Altera FPGAs using the CvP interface over PCIe.
>
> -config FPGA_MGR_TS73XX
> - tristate "Technologic Systems TS-73xx SBC FPGA Manager"
> - depends on ARCH_EP93XX && MACH_TS72XX
> +config FPGA_MGR_ZYNQ_FPGA
> + tristate "Xilinx Zynq FPGA"
> + depends on ARCH_ZYNQ || COMPILE_TEST
> + depends on HAS_DMA
> help
> - FPGA manager driver support for the Altera Cyclone II FPGA
> - present on the TS-73xx SBC boards.
> + FPGA manager driver support for Xilinx Zynq FPGAs.
>
> config FPGA_MGR_XILINX_SPI
> tristate "Xilinx Configuration over Slave Serial (SPI)"
> @@ -72,12 +64,18 @@ config FPGA_MGR_XILINX_SPI
> FPGA manager driver support for Xilinx FPGA configuration
> over slave serial interface.
>
> -config FPGA_MGR_ZYNQ_FPGA
> - tristate "Xilinx Zynq FPGA"
> - depends on ARCH_ZYNQ || COMPILE_TEST
> - depends on HAS_DMA
> +config FPGA_MGR_ICE40_SPI
> + tristate "Lattice iCE40 SPI"
> + depends on OF && SPI
> help
> - FPGA manager driver support for Xilinx Zynq FPGAs.
> + FPGA manager driver support for Lattice iCE40 FPGAs over SPI.
> +
> +config FPGA_MGR_TS73XX
> + tristate "Technologic Systems TS-73xx SBC FPGA Manager"
> + depends on ARCH_EP93XX && MACH_TS72XX
> + help
> + FPGA manager driver support for the Altera Cyclone II FPGA
> + present on the TS-73xx SBC boards.
>
> config FPGA_BRIDGE
> tristate "FPGA Bridge Framework"
> @@ -101,18 +99,6 @@ config ALTERA_FREEZE_BRIDGE
> isolate one region of the FPGA from the busses while that
> region is being reprogrammed.
>
> -config ALTERA_PR_IP_CORE
> - tristate "Altera Partial Reconfiguration IP Core"
> - help
> - Core driver support for Altera Partial Reconfiguration IP component
> -
> -config ALTERA_PR_IP_CORE_PLAT
> - tristate "Platform support of Altera Partial Reconfiguration IP Core"
> - depends on ALTERA_PR_IP_CORE && OF && HAS_IOMEM
> - help
> - Platform driver support for Altera Partial Reconfiguration IP
> - component
> -
> config XILINX_PR_DECOUPLER
> tristate "Xilinx LogiCORE PR Decoupler"
> depends on FPGA_BRIDGE
> @@ -123,4 +109,18 @@ config XILINX_PR_DECOUPLER
> region of the FPGA from the busses while that region is
> being reprogrammed during partial reconfig.
>
> +config FPGA_REGION
> + tristate "FPGA Region"
> + depends on FPGA_BRIDGE
> + help
> + FPGA Region common code. A FPGA Region controls a FPGA Manager
> + and the FPGA Bridges associated with either a reconfigurable
> + region of an FPGA or a whole FPGA.
> +
> +config OF_FPGA_REGION
> + tristate "FPGA Region Device Tree Overlay Support"
> + depends on OF && FPGA_REGION
> + help
> + Support for loading FPGA images under control of Device Tree.
> +
> endif # FPGA
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-09-14 15:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 20:48 [PATCH v4 00/18] Enable upper layers using FPGA region w/o device tree Alan Tull
2017-09-13 20:48 ` [PATCH v4 01/18] fpga: bridge: support getting bridge from device Alan Tull
2017-09-13 23:38 ` matthew.gerlach
2017-09-14 19:26 ` Alan Tull
2017-09-14 22:29 ` matthew.gerlach
2017-09-14 22:54 ` Moritz Fischer
2017-09-19 16:06 ` Alan Tull
2017-09-18 17:59 ` Moritz Fischer
2017-09-18 20:53 ` Alan Tull
2017-09-18 22:53 ` Moritz Fischer
2017-09-19 15:35 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 02/18] fpga: mgr: API change to replace fpga load functions with single function Alan Tull
2017-09-13 20:48 ` [PATCH v4 03/18] fpga: mgr: separate getting/locking FPGA manager Alan Tull
2017-09-13 20:48 ` [PATCH v4 04/18] fpga: region: use dev_err instead of pr_err Alan Tull
2017-09-18 18:17 ` Moritz Fischer
2017-09-18 20:54 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 05/18] fpga: region: remove unneeded of_node_get and put Alan Tull
2017-09-13 20:48 ` [PATCH v4 06/18] fpga: region: get mgr early on Alan Tull
2017-09-13 20:48 ` [PATCH v4 07/18] fpga: region: check for child regions before allocing image info Alan Tull
2017-09-13 20:48 ` [PATCH v4 08/18] fpga: region: fix slow warning with more than one overlay Alan Tull
2017-09-13 20:48 ` [PATCH v4 09/18] fpga: region: use image info as parameter for programming region Alan Tull
2017-09-13 20:48 ` [PATCH v4 10/18] fpga: region: separate out code that parses the overlay Alan Tull
2017-09-13 20:48 ` [PATCH v4 11/18] fpga: region: add fpga-region.h header Alan Tull
2017-09-14 9:50 ` Wu Hao
2017-09-14 19:36 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 12/18] fpga: region: rename some functions prior to moving Alan Tull
2017-09-13 20:48 ` [PATCH v4 13/18] fpga: region: add register/unregister functions Alan Tull
2017-09-14 9:56 ` Wu Hao
2017-09-14 20:03 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 14/18] fpga: region: add fpga_region_class_find Alan Tull
2017-09-13 20:48 ` [PATCH v4 15/18] fpga: region: move device tree support to of-fpga-region.c Alan Tull
2017-09-14 15:50 ` matthew.gerlach
2017-09-14 20:54 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 16/18] fpga: of-fpga-region: accept overlays that don't program FPGA Alan Tull
2017-09-13 20:48 ` [PATCH v4 17/18] fpga: clean up fpga Kconfig Alan Tull
2017-09-14 15:56 ` matthew.gerlach [this message]
2017-09-14 20:41 ` Alan Tull
2017-09-13 20:48 ` [PATCH v4 18/18] fpga: add attribute groups Alan Tull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709140856110.2384@mgerlach-VirtualBox \
--to=matthew.gerlach@linux.intel.com \
--cc=atull@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).