From: Julia Lawall <julia.lawall@lip6.fr>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-usb@vger.kernel.org, linux-spi@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, broonie@kernel.org, atull@kernel.org,
mdf@kernel.org, kbuild-all@01.org
Subject: [PATCH] usb: misc: fix boolconv.cocci warnings
Date: Wed, 21 Nov 2018 18:33:51 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1811211832430.2779@hadrien> (raw)
From: kbuild test robot <fengguang.wu@intel.com>
drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices")
CC: Anatolij Gustschin <agust@denx.de>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
Signd-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
url: https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago
Please take the patch only if it's a positive warning. Thanks!
ft232h-intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/misc/ft232h-intf.c
+++ b/drivers/usb/misc/ft232h-intf.c
@@ -813,7 +813,7 @@ static int ftdi_mpsse_gpio_get(struct gp
dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset);
- low = offset < 5 ? true : false;
+ low = offset < 5;
mutex_lock(&priv->ops_mutex);
next reply other threads:[~2018-11-22 4:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 17:33 Julia Lawall [this message]
2018-11-23 15:10 ` [PATCH] usb: misc: fix boolconv.cocci warnings Greg KH
2018-11-23 15:29 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1811211832430.2779@hadrien \
--to=julia.lawall@lip6.fr \
--cc=agust@denx.de \
--cc=atull@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).