From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:15667 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727787AbeKVEJN (ORCPT ); Wed, 21 Nov 2018 23:09:13 -0500 Date: Wed, 21 Nov 2018 18:33:51 +0100 (CET) From: Julia Lawall Subject: [PATCH] usb: misc: fix boolconv.cocci warnings Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-fpga-owner@vger.kernel.org List-Id: linux-fpga@vger.kernel.org To: Anatolij Gustschin Cc: linux-usb@vger.kernel.org, linux-spi@vger.kernel.org, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, broonie@kernel.org, atull@kernel.org, mdf@kernel.org, kbuild-all@01.org From: kbuild test robot drivers/usb/misc/ft232h-intf.c:816:27-32: WARNING: conversion to bool not needed here Remove unneeded conversion to bool Semantic patch information: Relational and logical operators evaluate to bool, explicit conversion is overly verbose and unneeded. Generated by: scripts/coccinelle/misc/boolconv.cocci Fixes: 0772a5bf580c ("usb: misc: add driver for FT232H based FPGA configuration devices") CC: Anatolij Gustschin Signed-off-by: kbuild test robot Signd-off-by: Julia Lawall --- url: https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181120-161201 :::::: branch date: 17 hours ago :::::: commit date: 17 hours ago Please take the patch only if it's a positive warning. Thanks! ft232h-intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/misc/ft232h-intf.c +++ b/drivers/usb/misc/ft232h-intf.c @@ -813,7 +813,7 @@ static int ftdi_mpsse_gpio_get(struct gp dev_dbg(chip->parent, "%s: offset %d\n", __func__, offset); - low = offset < 5 ? true : false; + low = offset < 5; mutex_lock(&priv->ops_mutex);