From: Jens Axboe <axboe@kernel.dk>
To: "Philipp Stanner" <pstanner@redhat.com>,
"Wu Hao" <hao.wu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Moritz Fischer" <mdf@kernel.org>,
"Xu Yilun" <yilun.xu@intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Alvaro Karsz" <alvaro.karsz@solid-run.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Hannes Reinecke" <hare@suse.de>,
"Keith Busch" <kbusch@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org,
virtualization@lists.linux.dev
Subject: Re: [PATCH v4 3/7] block: mtip32xx: Replace deprecated PCI functions
Date: Tue, 27 Aug 2024 13:05:43 -0600 [thread overview]
Message-ID: <c7acca0d-586f-41c0-a542-6b698305f17a@kernel.dk> (raw)
In-Reply-To: <20240827185616.45094-4-pstanner@redhat.com>
On 8/27/24 12:56 PM, Philipp Stanner wrote:
> pcim_iomap_regions() and pcim_iomap_table() have been deprecated by the
> PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()").
>
> In mtip32xx, these functions can easily be replaced by their respective
> successors, pcim_request_region() and pcim_iomap(). Moreover, the
> driver's calls to pcim_iounmap_regions() in probe()'s error path and in
> remove() are not necessary. Cleanup can be performed by PCI devres
> automatically.
>
> Replace pcim_iomap_regions() and pcim_iomap_table().
>
> Remove the calls to pcim_iounmap_regions().
Looks fine to me - since it depends on other trees, feel free to take it
through those:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2024-08-27 19:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 18:56 [PATCH v4 0/7] PCI: Remove pcim_iounmap_regions() Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 1/7] PCI: Deprecate pcim_iounmap_regions() Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 2/7] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 3/7] block: mtip32xx: " Philipp Stanner
2024-08-27 19:05 ` Jens Axboe [this message]
2024-08-28 7:10 ` Philipp Stanner
2024-08-28 14:49 ` Jens Axboe
2024-08-27 18:56 ` [PATCH v4 4/7] gpio: " Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 5/7] ethernet: cavium: " Philipp Stanner
2024-08-28 6:56 ` Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 6/7] vdpa: solidrun: Fix UB bug with devres Philipp Stanner
2024-08-27 18:56 ` [PATCH v4 7/7] vdap: solidrun: Replace deprecated PCI functions Philipp Stanner
2024-08-27 19:01 ` [PATCH v4 0/7] PCI: Remove pcim_iounmap_regions() Philipp Stanner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7acca0d-586f-41c0-a542-6b698305f17a@kernel.dk \
--to=axboe@kernel.dk \
--cc=alvaro.karsz@solid-run.com \
--cc=andy@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hao.wu@intel.com \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pstanner@redhat.com \
--cc=richardcochran@gmail.com \
--cc=trix@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).