From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Richard Gong Subject: Re: [PATCHv2 3/7] driver, misc: add Intel Stratix10 service layer driver References: <1519949975-13548-1-git-send-email-richard.gong@linux.intel.com> <1519949975-13548-4-git-send-email-richard.gong@linux.intel.com> <20180315164836.GB4060@kroah.com> Message-ID: Date: Fri, 16 Mar 2018 12:39:49 -0500 MIME-Version: 1.0 In-Reply-To: <20180315164836.GB4060@kroah.com> Content-Type: multipart/alternative; boundary="------------771345B80174378AC29F04CD" Content-Language: en-US To: Greg KH Cc: catalin.marinas@arm.com, will.deacon@arm.com, dinguyen@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, atull@kernel.org, mdf@kernel.org, arnd@arndb.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org, yves.vandervennet@linux.intel.com, Richard Gong List-ID: This is a multi-part message in MIME format. --------------771345B80174378AC29F04CD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Greg, Thanks for review. On 03/15/2018 11:48 AM, Greg KH wrote: > On Thu, Mar 01, 2018 at 06:19:31PM -0600,richard.gong@linux.intel.com wrote: >> +EXPORT_SYMBOL_GPL(request_svc_channel_byname); > All of your global symbols should have the same prefix, not a verb. So > this should be: > svc_channel_request_by_name(), right? > >> +EXPORT_SYMBOL_GPL(free_svc_channel); > svc_channel_free()? > >> +EXPORT_SYMBOL_GPL(intel_svc_send); > Wait, why doesn't the first ones have "intel_svc" in them? > > What is the difference here? > > Should they all just have "intel_svc_" as the prefix? > > Stick to one thing for all exported functions/variables please, it's the > only way we can attempt to keep our namespace "sane". Sure, I will make changes so that all exported functions will have "intel_svc_" as the prefix. > Also, why would a 'misc' driver be exporting things that something else > uses? Why not just put this in the fpga directory next to the users of > this code? Intel Stratix10 service layer driver, running at privileged exception level (EL1), interfaces with the service providers and providers the services for FPGA configuration, QSPI, Crypto, ECC, and warm reset. Service layer driver also manages secure monitor call to communicate with secure monitor code running at EL3. FPGA manager is the first service provider. Later we will add several service providers, and extend service layer driver to provide the services for QSPI, Crypto, ECC and warm reset. Regards, Richard > thanks, > > greg k-h --------------771345B80174378AC29F04CD Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Greg,

Thanks for review.

On 03/15/2018 11:48 AM, Greg KH wrote:

On Thu, Mar 01, 2018 at 06:19:31PM -0600, richard.gong@linux.intel.com wrote:

+EXPORT_SYMBOL_GPL(request_svc_channel_byname);

All of your global symbols should have the same prefix, not a verb.  So
this should be:
	svc_channel_request_by_name(), right?

+EXPORT_SYMBOL_GPL(free_svc_channel);

svc_channel_free()?

+EXPORT_SYMBOL_GPL(intel_svc_send);

Wait, why doesn't the first ones have "intel_svc" in them?

What is the difference here?

Should they all just have "intel_svc_" as the prefix?

Stick to one thing for all exported functions/variables please, it's the
only way we can attempt to keep our namespace "sane".

Sure, I will make changes so that all exported functions will have "intel_svc_" as the prefix.

Also, why would a 'misc' driver be exporting things that something else
uses?  Why not just put this in the fpga directory next to the users of
this code?

Intel Stratix10 service layer driver, running at privileged exception level (EL1), interfaces with
the service providers and providers the services for FPGA configuration, QSPI, Crypto, ECC,
and warm reset. Service layer driver also manages secure monitor call to communicate
with secure monitor code running at EL3.

FPGA manager is the first service provider. Later we will add several service providers, and extend
service layer driver to provide the services for QSPI, Crypto, ECC and warm reset.

Regards,
Richard

thanks,

greg k-h

--------------771345B80174378AC29F04CD--