Re: [PATCH v5 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings

[Krzysztof Kozlowski <krzk@kernel.org>]

On 20/11/2025 16:55, Ian Dannapel wrote:
> Hello Krzysztof,
> 
> On Thu, Nov 20, 2025 at 3:13 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - efinix,trion-spi
>>> +      - efinix,titanium-spi
>>> +      - efinix,topaz-spi
>>
>>
>> Nothing improved. You received comments about this - twice or more even
>> - so I feel like you just don't care about review.
> Sorry I am lost here, this is based on a similar driver, but it is
> probably very outdated.
> So the fallback pattern would be okay? Eg:
> items:
>       - enum:
>           - efinix,trion-config
>           - efinix,titanium-config
>           - efinix,topaz-config
>       - const: efinix,fpga-config
> Or would a single compatible be better since currently from the
> drivers perspective there is
> no difference in hardware?

Almost, because I think you asked about this and I instead asked to use
one specific device as the fallback. Choose the oldest device and use it
the fallback for two others. There is plenty of examples - including
example-schema - using it with oneOf syntax.

Best regards,
Krzysztof