From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521A1C433F5 for ; Wed, 6 Apr 2022 16:54:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238336AbiDFQy3 (ORCPT ); Wed, 6 Apr 2022 12:54:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238047AbiDFQyX (ORCPT ); Wed, 6 Apr 2022 12:54:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BD8ED21C733 for ; Wed, 6 Apr 2022 07:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649254705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ODOVaz/edmhBMoEaKgg2w+ntcwg87Ta6yU5ilJ/7uSY=; b=hAJblArK92wXhIjvmcbOlhTB6zUXxNJdaR0/p3Kz9ZCXCMKbBGAVMMCWsusvz8qK7luAAL v1S1RXlC0S646SVRqHGYamDwMNKZfW9EzcPVpn2PI6nd0yZq+4M2BNNqU2QyKXF4hEf6RK E4/Lok9hgN0tBcTA/rouZ9aGfenmkiY= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-XiLUwbo_OMWG_NGC5qJqSA-1; Wed, 06 Apr 2022 10:18:24 -0400 X-MC-Unique: XiLUwbo_OMWG_NGC5qJqSA-1 Received: by mail-qt1-f199.google.com with SMTP id m12-20020ac807cc000000b002e05dbf21acso2892529qth.22 for ; Wed, 06 Apr 2022 07:18:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ODOVaz/edmhBMoEaKgg2w+ntcwg87Ta6yU5ilJ/7uSY=; b=zcf3y0gSDh0uvnGMFCUvBXDfnoGl4H+9vbXF6pHjSATMH/SXWUYOkPRTyU7+4DGy9T mSr4N1oQ6gmy1a/L+cO3EgxEu/9ANeiBwoSEON5fllChmD8RxAtYHKJxhL8wJapkvP0x J87rLdpFLUIo5f3DKu5pkeFZAEEFnMJUOrfdnE+6OSLPsjmDEmChz5D6CaYmjO/ULMnS /9Bg7qAoAY1WoY95nSy8e5awaEhL6D8fYXXvuMRDtOQUniKtaz7W2cTDjiImqJ6WYJoD 5JtA0Ym8gDuILRGYsRL6GFTOZGQCy0qH6dkf7kZ1ZvXP+dm6ju7QY8nynG1+7w76MzQp Xhgw== X-Gm-Message-State: AOAM531YmYgJiCydr49wgeTAIfHGahGxTpyGlpiORnSRhwXxeq1GA1q4 0Rr9A0H9CypipJx7X0dD9wOlEES565/Py/dFdd9iFL7TMMyuct1Q+yQeGNbm0FtQENxOIPLud8a Ycy80w74MLHpv5cWloCJ0sA== X-Received: by 2002:ad4:5b8f:0:b0:443:5663:12ad with SMTP id 15-20020ad45b8f000000b00443566312admr7625111qvp.93.1649254703894; Wed, 06 Apr 2022 07:18:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5Ek+S4hfi61dB9TIY5eREbgIsa4+FJaeRcA2oPQoc6YVwJZraRCwA7foiQ+eI3V9hRLSlOQ== X-Received: by 2002:ad4:5b8f:0:b0:443:5663:12ad with SMTP id 15-20020ad45b8f000000b00443566312admr7625091qvp.93.1649254703704; Wed, 06 Apr 2022 07:18:23 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id a6-20020ae9e806000000b0067ba5a8a2a7sm9427968qkg.134.2022.04.06.07.18.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 07:18:23 -0700 (PDT) Subject: Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less than zero To: Marco Pagani , Moritz Fischer , Wu Hao , Xu Yilun Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220405185349.220607-1-marpagan@redhat.com> From: Tom Rix Message-ID: Date: Wed, 6 Apr 2022 07:18:21 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220405185349.220607-1-marpagan@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org On 4/5/22 11:53 AM, Marco Pagani wrote: > Fix the "comparison with less than zero" warning reported by > cppcheck for the unsigned (size_t) parameter "count" of the > "alt_pr_fpga_write()" function. > > Signed-off-by: Marco Pagani > --- > drivers/fpga/altera-pr-ip-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c > index be0667968d33..2ff3d8e46a0c 100644 > --- a/drivers/fpga/altera-pr-ip-core.c > +++ b/drivers/fpga/altera-pr-ip-core.c > @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf, > u32 *buffer_32 = (u32 *)buf; > size_t i = 0; > > - if (count <= 0) > + if (count == 0) > return -EINVAL; Reviewed-by: Tom Rix > > /* Write out the complete 32-bit chunks */