From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org
Cc: linuxarm@huawei.com, Shaokun Zhang <zhangshaokun@hisilicon.com>,
Yicong Yang <yangyicong@hisilicon.com>,
Jiucheng Xu <jiucheng.xu@amlogic.com>,
Khuong Dinh <khuong@os.amperecomputing.com>,
Atish Patra <atishp@atishpatra.org>,
Anup Patel <anup@brainfault.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Frank Li <Frank.li@nxp.com>,
Shuai Xue <xueshuai@linux.alibaba.com>,
Vineet Gupta <vgupta@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org, Liang Kan <kan.liang@linux.intel.com>
Subject: Re: [PATCH v2 16/30] perf/arm_pmu: Assign parents for event_source devices
Date: Tue, 16 Apr 2024 10:36:49 +0100 [thread overview]
Message-ID: <d8d5b480-ec59-4fc5-a726-34aec5575a8d@arm.com> (raw)
In-Reply-To: <20240412161057.14099-17-Jonathan.Cameron@huawei.com>
On 12/04/2024 17:10, Jonathan Cameron wrote:
> Currently the PMU device appears directly under /sys/devices/
> Only root busses should appear there, so instead assign the pmu->dev
> parent to be the platform device.
>
> Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/perf/arm_pmu_platform.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c
> index 3596db36cbff..4b1a9a92ea11 100644
> --- a/drivers/perf/arm_pmu_platform.c
> +++ b/drivers/perf/arm_pmu_platform.c
> @@ -196,6 +196,7 @@ int arm_pmu_device_probe(struct platform_device *pdev,
> if (!pmu)
> return -ENOMEM;
>
> + pmu->pmu.parent = &pdev->dev;
> pmu->plat_device = pdev;
>
> ret = pmu_parse_irqs(pmu);
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2024-04-16 9:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 16:10 [PATCH v2 00/30] Add parents to struct pmu -> dev Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 01/30] perf/hisi-pcie: Assign parent for event_source device Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 02/30] Documentation: hisi-pmu: Drop reference to /sys/devices path Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 03/30] perf/hisi-uncore: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 04/30] Documentation: hns-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 05/30] perf/hisi-hns3: Assign parents for event_source device Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 06/30] perf/amlogic: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 07/30] perf/arm_cspmu: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 08/30] Documentation: xgene-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 09/30] perf/xgene: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 10/30] Documentation: thunderx2-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 11/30] perf/thunderx2: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 12/30] perf/riscv: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 13/30] Documentation: qcom-pmu: Use /sys/bus/event_source/devices paths Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 14/30] perf/qcom: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 15/30] perf/imx_ddr: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 16/30] perf/arm_pmu: " Jonathan Cameron
2024-04-16 9:36 ` Suzuki K Poulose [this message]
2024-04-12 16:10 ` [PATCH v2 17/30] perf/alibaba_uncore: Assign parents for event_source device Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 18/30] perf/arm-cci: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 19/30] perf/arm-ccn: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 20/30] perf/arm-dmc620: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 21/30] perf/arm-dsu: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 22/30] perf/arm-smmuv3: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 23/30] perf/arm-spe: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 24/30] arc: Assign parents for event_source devices Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 25/30] ARM: imx: Assign parents for mmdc " Jonathan Cameron
2024-04-22 5:42 ` Shawn Guo
2024-04-12 16:10 ` [PATCH v2 26/30] dmaengine: idxd: Assign parent for event_source device Jonathan Cameron
2024-04-12 16:27 ` Dave Jiang
2024-04-15 19:05 ` Fenghua Yu
2024-04-12 16:10 ` [PATCH v2 27/30] fpga: dfl: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 28/30] drivers/nvdimm: " Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 29/30] Documentation: ABI + trace: hisi_ptt: update paths to bus/event_source Jonathan Cameron
2024-04-12 16:10 ` [PATCH v2 30/30] hwtracing: hisi_ptt: Assign parent for event_source device Jonathan Cameron
2024-04-16 9:38 ` Suzuki K Poulose
2024-04-19 15:33 ` [PATCH v2 00/30] Add parents to struct pmu -> dev Will Deacon
2024-05-02 11:09 ` [PATCH v2 00/30] (subset) " Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d5b480-ec59-4fc5-a726-34aec5575a8d@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Frank.li@nxp.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=acme@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=anup@brainfault.org \
--cc=atishp@atishpatra.org \
--cc=dave.jiang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=jiucheng.xu@amlogic.com \
--cc=kan.liang@linux.intel.com \
--cc=khuong@os.amperecomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shawnguo@kernel.org \
--cc=trix@redhat.com \
--cc=vgupta@kernel.org \
--cc=will@kernel.org \
--cc=xueshuai@linux.alibaba.com \
--cc=yangyicong@hisilicon.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).