From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40D498594D; Tue, 16 Apr 2024 09:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713260229; cv=none; b=qib9KZe1/9RSe0XB5IexRf+LHalugaNdTIPWpL/eylqpKguVo1w6MI0thBhQ+Ln6Jc+XZRdflFMFyPRdDboPRQWUYI4Sk1cCBunPOl4ZfdZqkRV8xhsFRf4e5YhIvh2vFEcSPPyqFXS/00eKpr/NrzZYtJ3iZLpzxnM1O0obw4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713260229; c=relaxed/simple; bh=yBI9KZPzbMre2zuqLdHyFt55ETKgaaVCW0a5Z76vWxc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QyhbPXpkEOba6coSfD9Trko56ynUvwsbrq/sFrr/UoY1X32MmboQmP/3EBabPvw13YvKAeJ0U2/a4N+XHrc87pjYVqRpNCokYHkLeaCl3z8TutneTPOqFsfLbXQUxewF0DTam+R1KWcTIXzQW4SLjSzt5gG+e0P+d22xexm+K0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C56EF339; Tue, 16 Apr 2024 02:37:35 -0700 (PDT) Received: from [10.1.197.1] (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B4893F792; Tue, 16 Apr 2024 02:37:04 -0700 (PDT) Message-ID: Date: Tue, 16 Apr 2024 10:36:49 +0100 Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 16/30] perf/arm_pmu: Assign parents for event_source devices To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org Cc: linuxarm@huawei.com, Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Liang Kan References: <20240412161057.14099-1-Jonathan.Cameron@huawei.com> <20240412161057.14099-17-Jonathan.Cameron@huawei.com> Content-Language: en-US From: Suzuki K Poulose In-Reply-To: <20240412161057.14099-17-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/04/2024 17:10, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the platform device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Signed-off-by: Jonathan Cameron > --- > drivers/perf/arm_pmu_platform.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/arm_pmu_platform.c b/drivers/perf/arm_pmu_platform.c > index 3596db36cbff..4b1a9a92ea11 100644 > --- a/drivers/perf/arm_pmu_platform.c > +++ b/drivers/perf/arm_pmu_platform.c > @@ -196,6 +196,7 @@ int arm_pmu_device_probe(struct platform_device *pdev, > if (!pmu) > return -ENOMEM; > > + pmu->pmu.parent = &pdev->dev; > pmu->plat_device = pdev; > > ret = pmu_parse_irqs(pmu); Reviewed-by: Suzuki K Poulose