From: Krzysztof Kozlowski <krzk@kernel.org>
To: iansdannapel@gmail.com, linux-fpga@vger.kernel.org
Cc: "Moritz Fischer" <mdf@kernel.org>, "Wu Hao" <hao.wu@intel.com>,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Aradhya Bhatia" <a-bhatia1@ti.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [v4 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings
Date: Sat, 1 Mar 2025 14:13:37 +0100 [thread overview]
Message-ID: <e08dbe2b-6f0c-4021-9d6b-f2205bd1c273@kernel.org> (raw)
In-Reply-To: <20250228094732.54642-3-iansdannapel@gmail.com>
On 28/02/2025 10:47, iansdannapel@gmail.com wrote:
> +
> + References:
> + - https://www.efinixinc.com/docs/an006-configuring-trion-fpgas-v6.3.pdf
> + - https://www.efinixinc.com/docs/an033-configuring-titanium-fpgas-v2.8.pdf
> + - https://www.efinixinc.com/docs/an061-configuring-topaz-fpgas-v1.1.pdf
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - efinix,trion-spi
> + - efinix,titanium-spi
> + - efinix,topaz-spi
Same comments as before about compatibility. Address or implement.
> + - efinix,fpga-spi
And this one is for which device? It is not even used.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-01 13:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:47 [v4 0/3] Add Efinix FPGA SPI programming support iansdannapel
2025-02-28 9:47 ` [v4 1/3] dt-bindings: vendor-prefix: Add prefix for Efinix, Inc iansdannapel
2025-02-28 18:29 ` Conor Dooley
2025-03-01 13:10 ` Krzysztof Kozlowski
2025-03-04 11:24 ` Alexander Dahl
2025-02-28 9:47 ` [v4 2/3] dt-bindings: fpga: Add Efinix SPI programming bindings iansdannapel
2025-02-28 18:28 ` Conor Dooley
2025-03-03 10:10 ` Ian Dannapel
2025-03-03 10:29 ` Ian Dannapel
2025-03-03 10:33 ` Krzysztof Kozlowski
2025-03-03 10:31 ` Conor Dooley
2025-03-03 10:34 ` Krzysztof Kozlowski
2025-03-01 13:13 ` Krzysztof Kozlowski [this message]
2025-02-28 9:47 ` [v4 3/3] fpga-mgr: Add Efinix SPI programming driver iansdannapel
2025-03-03 11:57 ` Manne, Nava kishore
2025-03-03 12:16 ` Ian Dannapel
2025-03-16 15:03 ` Xu Yilun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e08dbe2b-6f0c-4021-9d6b-f2205bd1c273@kernel.org \
--to=krzk@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=a-bhatia1@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hao.wu@intel.com \
--cc=iansdannapel@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).