From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx.nabladev.com (mx.nabladev.com [178.251.229.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E0B3A9DB2; Thu, 23 Jul 2026 05:58:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.251.229.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784786285; cv=none; b=DEjI8ctx/cUO+bGBLrAsUBDe9kwsVht4THTuWXjtwu/OT9Bi61/So9gTnolCikgxZygEMIKmkL7whofNUoDXmN//hMU7st720NxQ/acT/D8+0GpFJUHAoPFPkdTyRmwc1dYDbilLGyKa0lLkSg8sdg0jBgB8K+l3M88FR1VPpfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784786285; c=relaxed/simple; bh=kiigGFy6X70ni15Fuj+SkHLw0rkwe7NT/HF1gNSWpRU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YP7NeamWHfL02wIGmwYsNgJsWKLKFD+oGo7A0S3d0iK8u6qaM1LSr9ZyzQJzhtPWeTVEqiG4ZBYiP/R6cbrT9viQD+l0OzMMX0nys1wt355DKzeWmQxqX9tGTYLOUy8kuTLVdRmT2p8mAD4IRZZ7MT86XVyReSph4YmpV1+OqXM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com; spf=pass smtp.mailfrom=nabladev.com; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b=hh68P83t; arc=none smtp.client-ip=178.251.229.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nabladev.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nabladev.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nabladev.com header.i=@nabladev.com header.b="hh68P83t" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 38C6F11AAAF; Thu, 23 Jul 2026 07:57:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nabladev.com; s=dkim; t=1784786280; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=VFjmYyF5VPe289BlZka42WgXUPRX6vAouN/83LGa2YM=; b=hh68P83tVlCq+MrKUy8gJALRL7rhCyDkN1Pi00vwD2s2jdwSYHIP4Ve3cfVprbVHBiqxet 8UgeJeTtmTYSfG5ovBt9o7mZz6YnkVe5OMuYlD+RMSfcphEJxAGXCBybdiUUTKlSk5BDPv IqePL5a4HrB9rNFRNhX1qhFVeD2UY4VTf3UtUce55koGDX1OANBSfjC6c5OVbfSHQA2bEA o+lmLwYQhS+jYBQCU0bYck+UOPDGT+3ixUj676dz8g3GaIpbjRda1OV/zYJHahn4lcbWqI DiredCqBq3i9rLsZWRB/d2pfqWETwWIN3JFqoO4uUcrIwsWk+BAyashW0vedlg== Message-ID: Date: Thu, 23 Jul 2026 07:57:23 +0200 Precedence: bulk X-Mailing-List: linux-fpga@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] driver: fpga: xilinx-selectmap: add csi and rdwr support Content-Language: en-US To: Michal Simek , linux-kernel@vger.kernel.org Cc: linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Moritz Fischer , Tom Rix , Xu Yilun References: <20260721114258.3324794-1-hs@nabladev.com> <2758c5dc-91fa-44a0-986e-1258afc3dbd5@amd.com> <855f458a-60d7-931f-9ef9-5dba2b2d916d@nabladev.com> <98e8e7d4-38d9-4587-bf11-0e862f87928c@amd.com> From: Heiko Schocher In-Reply-To: <98e8e7d4-38d9-4587-bf11-0e862f87928c@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hello Michal, On 23.07.26 07:44, Michal Simek wrote: > > > On 7/22/26 16:45, Heiko Schocher wrote: >> Hello Michal, >> >> On 22.07.26 08:55, Michal Simek wrote: >>> >>> >>> On 7/21/26 13:42, Heiko Schocher wrote: >>>> Add csi_b and rdwr pin support for the xilinx,selectmap driver. >>>> >>>> In current driver the pins are configured from DTS and set to >>>> GPIOD_OUT_HIGH. This works in case you have one FPGA. >>>> >>>> Extend this to really implement csi_b and rdwr pin function in >>>> driver, so it works with more than one FPGA. >>>> >>>> Tested on AM625 based board with 2 FPGAs connected to GPMC. >>>> >>>> Signed-off-by: Heiko Schocher >>>> --- >>>> >>>> Changes in v2: >>>> - add comments from Michal >>>>    - skip check if gpio descriptor variables csi_b/rdwr_b are valid, >>>>      as validate_desc() checks this in gpiod_set_value() call. >>>>    - initialize the gpio variables csi_b/rdwr_b immediately with >>>>      the return value from devm_gpiod_get_optional(), so we can >>>>      drop local gpio variable at all >>>> >>>>   drivers/fpga/xilinx-selectmap.c | 23 ++++++++++++++++------- >>>>   1 file changed, 16 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/drivers/fpga/xilinx-selectmap.c b/drivers/fpga/xilinx-selectmap.c >>>> index d0cbb5fdfe3a..d5175f9430e4 100644 >>>> --- a/drivers/fpga/xilinx-selectmap.c >>>> +++ b/drivers/fpga/xilinx-selectmap.c >>>> @@ -19,6 +19,8 @@ >>>>   struct xilinx_selectmap_conf { >>>>       struct xilinx_fpga_core core; >>>>       void __iomem *base; >>>> +    struct gpio_desc *csi_b; >>>> +    struct gpio_desc *rdwr_b; >>>>   }; >>>>   #define to_xilinx_selectmap_conf(obj) \ >>>> @@ -30,16 +32,21 @@ static int xilinx_selectmap_write(struct xilinx_fpga_core *core, >>>>       struct xilinx_selectmap_conf *conf = to_xilinx_selectmap_conf(core); >>>>       size_t i; >>>> +    gpiod_set_value(conf->csi_b, GPIOD_OUT_HIGH); >>>> +    gpiod_set_value(conf->rdwr_b, GPIOD_OUT_HIGH); >>> >>> I think GPIOD_OUT_HIGH/LOW is wrong in this context. >>> If you do "git grep gpiod_set_value" you will see that values are 0/1 >> I will change it! >> >> Hmm.. while thinking about it... CSI_B and RDWR_B signals >> are defined as active low... > > I have never worked with this driver but values here should be 0 or 1. And if that means active > low/high is said via DT. > > GPIOD_OUT_LOW below should mean that you are starting in deassert state (if it is low/high is coming > from DT). And before write you assert that line and deassert after it. Fine for me, I rework it, thanks! bye, Heiko > > Thanks, > Michal > > -- Nabla Software Engineering HRB 40522 Augsburg Phone: +49 821 45592596 E-Mail: office@nabladev.com Geschäftsführer : Stefano Babic