From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>, Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Moritz Fischer <mdf@kernel.org>, Tom Rix <trix@redhat.com>,
Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:FPGA MANAGER FRAMEWORK" <linux-fpga@vger.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: fpga: Convert fpga-region binding to yaml
Date: Thu, 25 Jan 2024 12:02:48 +0100 [thread overview]
Message-ID: <ec96c9cd-4734-4265-9693-d997eddccf93@linaro.org> (raw)
In-Reply-To: <20240119233231.GA1290941-robh@kernel.org>
On 20/01/2024 00:32, Rob Herring wrote:
> On Thu, Jan 18, 2024 at 01:34:16PM +0100, Michal Simek wrote:
>>
>>
>> On 1/17/24 22:47, Rob Herring wrote:
>>> On Wed, Jan 17, 2024 at 12:30:58PM +0100, Michal Simek wrote:
>
>>>> +additionalProperties: true
>>>
>>> Why? This should only be used if another schema is going to include this
>>> one. That's not the case here.
>>
>> In v2 we discussed this with Krzysztof. I used pattern properties from
>> simple-bus.yaml in v2.
>>
>> https://lore.kernel.org/all/b2dd8bcd-1e23-4b68-b7b7-c01b034fc1fe@linaro.org/
>
> You didn't answer his question. You just picked up
> 'additionalProperties: true' which is easy because it avoids 'problems'.
>
> His question was is this a common schema referenced by other schemas? If
> so, then use 'additionalProperties: true'. But it is not. You've
> defined exactly what 'compatible' must be and that means it can't be a
> common schema.
Yes, I missed that it has a compatible, so it is not expected to be
referenced from other schema, thus it should end with
'additionalProperties: false'.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-25 11:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 11:30 [PATCH v3] dt-bindings: fpga: Convert fpga-region binding to yaml Michal Simek
2024-01-17 21:47 ` Rob Herring
2024-01-18 12:34 ` Michal Simek
2024-01-19 23:32 ` Rob Herring
2024-01-25 11:02 ` Krzysztof Kozlowski [this message]
2024-01-25 11:47 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec96c9cd-4734-4265-9693-d997eddccf93@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=hao.wu@intel.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).