linux-fpga.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 0/2] Enable FPGA Manager support for Agilex5
@ 2025-11-19  2:26 Khairul Anuar Romli
  2025-11-19  2:26 ` [PATCH v6 1/2] dt-bindings: fpga: stratix10: add " Khairul Anuar Romli
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Khairul Anuar Romli @ 2025-11-19  2:26 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Mahesh Rao, Ho Yin,
	Niravkumar L Rabara, linux-fpga, linux-kernel, devicetree,
	Khairul Anuar Romli

This patch series adds device tree bindings, driver and DTS updates to
enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and FPGA management
capabilities on Agilex5-based platforms.

---
Notes:
Patch #2 depends on  "arm64: dts: intel: Add Agilex5 SVC node with memory
region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Changes in v6:
	- use items - const for Agilex5 to support fallback
	- Validate bindings through DTBS_CHECK=y by itself and agaist
          non-fallback (stratix10, agilex) and fallback (agilex5).
Changes in v5:
	- Revert back to oneOf and use enum without items.
Changes in v4:
	- Simplify the compatible property to use enum without items.
	- Use contains instead of oneOf due to the use of enum without items.
Changes in v3:
	- Add fallback in altera's soc fpga manager compatible properties.
	- Validate with make CHECK_DBTS=y on:
	  - intel/socfpga_agilex5_socdk.dtb (fallback)
          - intel/socfpga_agilex_socdk.dtb (non-fallback)
          - altera/socfpga_stratix10_socdk.dtb (non-fallback)
Changes in v2:
	- Drop "fpga: stratix10-soc: Add support for Agilex5"
	- Add fallback compatible in DT
---
Khairul Anuar Romli (2):
  dt-bindings: fpga: stratix10: add support for Agilex5
  arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

 .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml  | 10 +++++++---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi       | 12 ++++++++++++
 2 files changed, 19 insertions(+), 3 deletions(-)

-- 
2.43.7


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v6 1/2] dt-bindings: fpga: stratix10: add support for Agilex5
  2025-11-19  2:26 [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Khairul Anuar Romli
@ 2025-11-19  2:26 ` Khairul Anuar Romli
  2025-11-19 18:36   ` Conor Dooley
  2025-11-19  2:26 ` [PATCH v6 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes Khairul Anuar Romli
  2025-11-20  3:08 ` [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Dinh Nguyen
  2 siblings, 1 reply; 6+ messages in thread
From: Khairul Anuar Romli @ 2025-11-19  2:26 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Mahesh Rao, Ho Yin,
	Niravkumar L Rabara, linux-fpga, linux-kernel, devicetree,
	Khairul Anuar Romli

Agilex5 introduces changes in how reserved memory is mapped and accessed
compared to previous SoC generations. Agilex5 compatible allows stratix10-
FPGA manager driver to handle these changes.

Fallback is added for driver probe and init that rely on matching of table
and DT node.

Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v6:
	- Use items - const for Agilex5 to support fallback.
	- Validate bindings with dt-schema by itself and against fallback
	  and non-fallback.
Changes in v5:
	- Revert to oneOf and use enum without items.
Changes in v4:
	- Remove redundant "items - enum" as suggested in v3.
	- Simplify compatible property to use contains instead of oneOf.
	- Validate fallback and non-fallback DT. Also validate binding with
          dt_binding_check.
Changes in v3:
	- Add description for Agilex5 Device
	- Add and define fallback to "intel,agilex-soc-fpga-mgr"
	- Validate against Agilex and Stratix10 (non-fallback) and Agilex5
	  (fallback)
Changes in v2:
	- No changes in this patch
---
 .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml    | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
index 6e536d6b28a9..fff88c8e5e03 100644
--- a/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
+++ b/Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml
@@ -20,9 +20,13 @@ description:
 
 properties:
   compatible:
-    enum:
-      - intel,stratix10-soc-fpga-mgr
-      - intel,agilex-soc-fpga-mgr
+    oneOf:
+      - enum:
+          - intel,stratix10-soc-fpga-mgr
+          - intel,agilex-soc-fpga-mgr
+      - items:
+          - const: intel,agilex5-soc-fpga-mgr
+          - const: intel,agilex-soc-fpga-mgr
 
 required:
   - compatible
-- 
2.43.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v6 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
  2025-11-19  2:26 [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Khairul Anuar Romli
  2025-11-19  2:26 ` [PATCH v6 1/2] dt-bindings: fpga: stratix10: add " Khairul Anuar Romli
@ 2025-11-19  2:26 ` Khairul Anuar Romli
  2025-11-20  3:08 ` [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Dinh Nguyen
  2 siblings, 0 replies; 6+ messages in thread
From: Khairul Anuar Romli @ 2025-11-19  2:26 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Mahesh Rao, Ho Yin,
	Niravkumar L Rabara, linux-fpga, linux-kernel, devicetree,
	Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires
proper device tree description to enable FPGA manager support in the Linux
kernel.

The fpga-region node is introduced to support FPGA partial reconfiguration
through the FPGA Manager framework. This node defines a region in the
device tree that can be dynamically programmed at runtime.

Reviewed-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>
---
Changes in v6:
	- No change.
Changes in v5:
	- No change.
Changes in v4:
	- No changes.
	- Validated with CHECK_DTBS=y as standalone and with
          intel,stratix10-soc-fpga-mgr.yaml
Changes in v3:
	- tested with intel,stratix10-soc-fpga-mgr.yaml
	- Rephrase commit message to make it more concise.
Changes in v2:
	- All fallback compatible string to ensure driver is still able to
	  initialize without new compatible string added in the driver.
---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
index a5c2025a616e..1f5d560f97b2 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi
@@ -85,9 +85,21 @@ svc {
 			method = "smc";
 			memory-region = <&service_reserved>;
 			iommus = <&smmu 10>;
+
+			fpga_mgr: fpga-mgr {
+				compatible = "intel,agilex5-soc-fpga-mgr",
+					     "intel,agilex-soc-fpga-mgr";
+			};
 		};
 	};
 
+	fpga-region {
+		compatible = "fpga-region";
+		#address-cells = <0x2>;
+		#size-cells = <0x2>;
+		fpga-mgr = <&fpga_mgr>;
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
-- 
2.43.7


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v6 1/2] dt-bindings: fpga: stratix10: add support for Agilex5
  2025-11-19  2:26 ` [PATCH v6 1/2] dt-bindings: fpga: stratix10: add " Khairul Anuar Romli
@ 2025-11-19 18:36   ` Conor Dooley
  0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2025-11-19 18:36 UTC (permalink / raw)
  To: Khairul Anuar Romli
  Cc: Moritz Fischer, Xu Yilun, Tom Rix, Dinh Nguyen, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Mahesh Rao, Ho Yin,
	Niravkumar L Rabara, linux-fpga, linux-kernel, devicetree

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

On Wed, Nov 19, 2025 at 10:26:05AM +0800, Khairul Anuar Romli wrote:
> Agilex5 introduces changes in how reserved memory is mapped and accessed
> compared to previous SoC generations. Agilex5 compatible allows stratix10-
> FPGA manager driver to handle these changes.
> 
> Fallback is added for driver probe and init that rely on matching of table
> and DT node.
> 
> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Khairul Anuar Romli <khairul.anuar.romli@altera.com>

\x02
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v6 0/2] Enable FPGA Manager support for Agilex5
  2025-11-19  2:26 [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Khairul Anuar Romli
  2025-11-19  2:26 ` [PATCH v6 1/2] dt-bindings: fpga: stratix10: add " Khairul Anuar Romli
  2025-11-19  2:26 ` [PATCH v6 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes Khairul Anuar Romli
@ 2025-11-20  3:08 ` Dinh Nguyen
  2025-11-20  3:17   ` Romli, Khairul Anuar
  2 siblings, 1 reply; 6+ messages in thread
From: Dinh Nguyen @ 2025-11-20  3:08 UTC (permalink / raw)
  To: Khairul Anuar Romli, Moritz Fischer, Xu Yilun, Tom Rix,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Mahesh Rao,
	Ho Yin, Niravkumar L Rabara, linux-fpga, linux-kernel, devicetree



On 11/18/25 20:26, Khairul Anuar Romli wrote:
> This patch series adds device tree bindings, driver and DTS updates to
> enable FPGA Manager functionality for Intel Agilex5 SoC.
> 
> These changes are intended to enable FPGA programming and FPGA management
> capabilities on Agilex5-based platforms.
> 

> ---
> Khairul Anuar Romli (2):
>    dt-bindings: fpga: stratix10: add support for Agilex5
>    arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
> 

Applied!

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v6 0/2] Enable FPGA Manager support for Agilex5
  2025-11-20  3:08 ` [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Dinh Nguyen
@ 2025-11-20  3:17   ` Romli, Khairul Anuar
  0 siblings, 0 replies; 6+ messages in thread
From: Romli, Khairul Anuar @ 2025-11-20  3:17 UTC (permalink / raw)
  To: Dinh Nguyen, Moritz Fischer, Xu Yilun, Tom Rix, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Rao, Mahesh, Ng, Adrian Ho Yin,
	Rabara, Niravkumar Laxmidas, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org

On 20/11/2025 11:08 am, Dinh Nguyen wrote:
> 
> 
> On 11/18/25 20:26, Khairul Anuar Romli wrote:
>> This patch series adds device tree bindings, driver and DTS updates to
>> enable FPGA Manager functionality for Intel Agilex5 SoC.
>>
>> These changes are intended to enable FPGA programming and FPGA management
>> capabilities on Agilex5-based platforms.
>>
> 
>> ---
>> Khairul Anuar Romli (2):
>>    dt-bindings: fpga: stratix10: add support for Agilex5
>>    arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
>>
> 
> Applied!
> 
> Thanks,
> Dinh

Thank You so much everyone for the reviews and feedback. Really 
appreciate it.

Best Regards,
Khairul

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-11-20  3:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-19  2:26 [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Khairul Anuar Romli
2025-11-19  2:26 ` [PATCH v6 1/2] dt-bindings: fpga: stratix10: add " Khairul Anuar Romli
2025-11-19 18:36   ` Conor Dooley
2025-11-19  2:26 ` [PATCH v6 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes Khairul Anuar Romli
2025-11-20  3:08 ` [PATCH v6 0/2] Enable FPGA Manager support for Agilex5 Dinh Nguyen
2025-11-20  3:17   ` Romli, Khairul Anuar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).