From: Philipp Stanner <pstanner@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Wu Hao <hao.wu@intel.com>,
Tom Rix <trix@redhat.com>, Moritz Fischer <mdf@kernel.org>,
Xu Yilun <yilun.xu@intel.com>, Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Richard Cochran <richardcochran@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
Hannes Reinecke <hare@suse.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Li Zetao <lizetao1@huawei.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org,
netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users
Date: Mon, 28 Oct 2024 16:05:06 +0100 [thread overview]
Message-ID: <f1ecab3f7703cd251275ecb141cbb4a24acafa2b.camel@redhat.com> (raw)
In-Reply-To: <20241016094911.24818-2-pstanner@redhat.com>
@Bjorn:
Are you OK with taking this?
Regards,
P.
On Wed, 2024-10-16 at 11:49 +0200, Philipp Stanner wrote:
> Merge plan for this is the PCI-Tree.
>
> After this series, only two users (net/ethernet/stmicro and
> vdpa/solidrun) will remain to be ported in the subsequent merge
> window.
> Doing them right now proved very difficult because of various
> conflicts
> as they are currently also being reworked.
>
> Changes in v8:
> - Patch "gpio: ..": Fix a bug: don't print the wrong error code.
> (Simon)
> - Split patch 1 into two patches to make adding of the new public
> API
> obvious (Bartosz)
> - Patch "ethernet: cavium: ...": Remove outdated sentences from the
> commit message.
>
> Changes in v7:
> - Add Paolo's Acked-by.
> - Rebase on current master; drop patch No.1 which made
> pcim_request_region() public.
>
> Changes in v6:
> - Remove the patches for "vdpa: solidrun" since the maintainer
> seems
> unwilling to review and discuss, not to mention approve, anything
> that is part of a wider patch series across other subsystems.
> - Change series's name to highlight that not all callers are
> removed
> by it.
>
> Changes in v5:
> - Patch "ethernet: cavium": Re-add accidentally removed
> pcim_iounmap_region(). (Me)
> - Add Jens's Reviewed-by to patch "block: mtip32xx". (Jens)
>
> Changes in v4:
> - Drop the "ethernet: stmicro: [...] patch since it doesn't apply
> to
> net-next, and making it apply to that prevents it from being
> applyable to PCI ._. (Serge, me)
> - Instead, deprecate pcim_iounmap_regions() and keep "ethernet:
> stimicro" as the last user for now.
> - ethernet: cavium: Use PTR_ERR_OR_ZERO(). (Andy)
> - vdpa: solidrun (Bugfix) Correct wrong printf string (was "psnet"
> instead of
> "snet"). (Christophe)
> - vdpa: solidrun (Bugfix): Add missing blank line. (Andy)
> - vdpa: solidrun (Portation): Use PTR_ERR_OR_ZERO(). (Andy)
> - Apply Reviewed-by's from Andy and Xu Yilun.
>
> Changes in v3:
> - fpga/dfl-pci.c: remove now surplus wrapper around
> pcim_iomap_region(). (Andy)
> - block: mtip32xx: remove now surplus label. (Andy)
> - vdpa: solidrun: Bugfix: Include forgotten place where stack UB
> occurs. (Andy, Christophe)
> - Some minor wording improvements in commit messages. (Me)
>
> Changes in v2:
> - Add a fix for the UB stack usage bug in vdap/solidrun. Separate
> patch, put stable kernel on CC. (Christophe, Andy).
> - Drop unnecessary pcim_release_region() in mtip32xx (Andy)
> - Consequently, drop patch "PCI: Make pcim_release_region() a
> public
> function", since there's no user anymore. (obsoletes the squash
> requested by Damien).
> - vdap/solidrun:
> • make 'i' an 'unsigned short' (Andy, me)
> • Use 'continue' to simplify loop (Andy)
> • Remove leftover blank line
> - Apply given Reviewed- / acked-bys (Andy, Damien, Bartosz)
>
>
> Important things first:
> This series is based on [1] and [2] which Bjorn Helgaas has currently
> queued for v6.12 in the PCI tree.
>
> This series shall remove pcim_iounmap_regions() in order to make way
> to
> remove its brother, pcim_iomap_regions().
>
> Regards,
> P.
>
> [1]
> https://lore.kernel.org/all/20240729093625.17561-4-pstanner@redhat.com/
> [2]
> https://lore.kernel.org/all/20240807083018.8734-2-pstanner@redhat.com/
>
> Philipp Stanner (6):
> PCI: Make pcim_iounmap_region() a public function
> PCI: Deprecate pcim_iounmap_regions()
> fpga/dfl-pci.c: Replace deprecated PCI functions
> block: mtip32xx: Replace deprecated PCI functions
> gpio: Replace deprecated PCI functions
> ethernet: cavium: Replace deprecated PCI functions
>
> drivers/block/mtip32xx/mtip32xx.c | 18 ++++++++--------
> --
> drivers/fpga/dfl-pci.c | 16 ++++------------
> drivers/gpio/gpio-merrifield.c | 15 ++++++++-------
> .../net/ethernet/cavium/common/cavium_ptp.c | 7 +++----
> drivers/pci/devres.c | 8 ++++++--
> include/linux/pci.h | 1 +
> 6 files changed, 30 insertions(+), 35 deletions(-)
>
next prev parent reply other threads:[~2024-10-28 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 9:49 [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 1/6] PCI: Make pcim_iounmap_region() a public function Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 2/6] PCI: Deprecate pcim_iounmap_regions() Philipp Stanner
2024-10-16 10:38 ` Andy Shevchenko
2024-10-18 10:52 ` Philipp Stanner
2024-10-18 12:36 ` Andy Shevchenko
2024-10-16 9:49 ` [PATCH v8 3/6] fpga/dfl-pci.c: Replace deprecated PCI functions Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 4/6] block: mtip32xx: " Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 5/6] gpio: " Philipp Stanner
2024-10-16 9:49 ` [PATCH v8 6/6] ethernet: cavium: " Philipp Stanner
2024-10-28 15:05 ` Philipp Stanner [this message]
2024-10-30 21:15 ` [PATCH v8 0/6] PCI: Remove most pcim_iounmap_regions() users Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ecab3f7703cd251275ecb141cbb4a24acafa2b.camel@redhat.com \
--to=pstanner@redhat.com \
--cc=andy@kernel.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=dlemoal@kernel.org \
--cc=edumazet@google.com \
--cc=hao.wu@intel.com \
--cc=hare@suse.de \
--cc=kch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=mdf@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=trix@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).