From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "boojin.kim" Subject: Re: [PATCH 5/9] block: support diskcipher Date: Thu, 22 Aug 2019 09:54:38 +0900 Message-ID: <017901d55884$2cbc8f60$8635ae20$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Language: ko Content-Type: text/plain; charset="utf-8" References: To: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: 'Herbert Xu' , "'David S. Miller'" , 'Eric Biggers' , "'Theodore Y. Ts'o' , 'Chao Yu' , 'Jaegeuk Kim' " , 'Andreas Dilger' 'Theodore Ts'o' , dm-devel@redhat.com, 'Mike Snitzer' , 'Alasdair Kergon' , 'Krzysztof Kozlowski' , 'Kukjin Kim' , 'Jaehoon Chung' , "'Ulf Hansson' , ," , linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.netlinux-samsung-soc, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org List-ID: On 8/21/19 21:09 AM, Jens Axboe wrote: > This isn't going to happen. With this, and the inline encryption > proposed by Google, we'll bloat the bio even more. At least the Google > approach didn't include bio iter changes as well. > Please work it out between yourselves so we can have a single, clean > abstraction that works for both. I'm looking at inline encryption by Google. I will find compatibility with inline encryption to avoid conflicts in BIO/F2FS. And changing bio iter has a benefit for diskcipher. Without changing bio iter, diskcipher should control(alloc/free) a buffer to hold a 'bi_dun' variable for every bio. But changing bio iter is difficult to accept for block layer, I will modify the diskcipher. And, as you mentioned, inline encryption by Google has this control. So I might be able to use it. Thanks. Boojin Kim.