From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "boojin.kim" Subject: Re: [PATCH 6/9] dm crypt: support diskcipher Date: Fri, 23 Aug 2019 13:20:37 +0900 Message-ID: <017901d5596a$1df3a590$59daf0b0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Language: ko Content-Type: text/plain; charset="utf-8" References: To: 'Herbert Xu' Cc: "'David S. Miller'" , 'Eric Biggers' , "'Theodore Y. Ts'o' , 'Chao Yu' , 'Jaegeuk Kim' " , 'Andreas Dilger' 'Theodore Ts'o' , dm-devel@redhat.com, 'Mike Snitzer' , 'Alasdair Kergon' , 'Jens Axboe' , 'Krzysztof Kozlowski' , 'Kukjin Kim' , 'Jaehoon Chung' , "'Ulf Hansson' , ," , linux-fscrypt@vger.kernel.org, linux-mmc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.netlinux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org List-ID: On Wed, Aug 21, 2019 at 17:19:41PM +0900, Herbert Xu wrote: > On Wed, Aug 21, 2019 at 04:57:41PM +0900, boojin.kim wrote: > > > > Can you tell me which patch you mentioned? Is this? > > https://patches.linaro.org/project/linux-crypto/list/?series=22762 > > > > Yes this is the one. > > Cheers, I looked at ESSIV patch-set. Can you please confirm that you mean: 'Register FMP as the template of skcipher instead of diskcipher, and simplify the interface for FMP user' If yes, I think the following API needs to be added to skcipher: - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO. - _mergeable(): Block layer checks if two BIOs have the same cipher. - _get(): Storage driver gets cipher from BIO. - _set_crypt(): Storage driver gets crypto information from cipher and writes it on the descriptor of Storage controller. Is it acceptable to skcipher ?