Re: [PATCH 4/4] fs-verity: move structs needed for file signing to UAPI header

[Luca Boccassi <Luca.Boccassi@microsoft.com>]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On Fri, 2020-11-13 at 13:19 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Although it isn't used directly by the ioctls,
> "struct fsverity_descriptor" is required by userspace programs that need
> to compute fs-verity file digests in a standalone way.  Therefore
> it's also needed to sign files in a standalone way.
> 
> Similarly, "struct fsverity_formatted_digest" (previously called
> "struct fsverity_signed_digest" which was misleading) is also needed to
> sign files if the built-in signature verification is being used.
> 
> Therefore, move these structs to the UAPI header.
> 
> While doing this, try to make it clear that the signature-related fields
> in fsverity_descriptor aren't used in the file digest computation.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  Documentation/filesystems/fsverity.rst |  6 +---
>  fs/verity/fsverity_private.h           | 37 -------------------
>  include/uapi/linux/fsverity.h          | 49 ++++++++++++++++++++++++++
>  3 files changed, 50 insertions(+), 42 deletions(-)

Acked-by: Luca Boccassi <luca.boccassi@microsoft.com>

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 484 bytes --]