From: Eric Biggers <ebiggers3@gmail.com>
To: "Theodore Y . Ts'o" <tytso@mit.edu>
Cc: linux-fscrypt@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] fs/crypto/hooks.c: fix build with pre-4.6 gcc versions
Date: Thu, 25 Jan 2018 10:42:29 -0800 [thread overview]
Message-ID: <20180125184229.xhq73ad2el4dafh4@gmail.com> (raw)
In-Reply-To: <20180119135348.57f9efad999c62d93b95f9fa@linux-foundation.org>
On Fri, Jan 19, 2018 at 01:53:48PM -0800, Andrew Morton wrote:
> On Fri, 19 Jan 2018 13:45:24 -0800 Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > From: Eric Biggers <ebiggers@google.com>
> >
> > gcc versions prior to 4.6 require an extra level of braces when using a
> > designated initializer for a member in an anonymous struct or union.
> > This caused a compile error with the 'struct qstr' initialization in
> > __fscrypt_encrypt_symlink().
> >
> > Fix it by using QSTR_INIT().
> >
> > Reported-by: Andrew Morton <akpm@linux-foundation.org>
> > Fixes: 76e81d6d5048 ("fscrypt: new helper functions for ->symlink()")
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>
> Tested-by: Andrew Morton <akpm@linux-foundation.org>
Ted, can you apply this to the fscrypt tree?
next prev parent reply other threads:[~2018-01-25 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 21:45 [PATCH] fs/crypto/hooks.c: fix build with pre-4.6 gcc versions Eric Biggers
2018-01-19 21:53 ` Andrew Morton
2018-01-25 18:42 ` Eric Biggers [this message]
2018-01-29 18:10 ` Eric Biggers
2018-02-01 15:52 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125184229.xhq73ad2el4dafh4@gmail.com \
--to=ebiggers3@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@google.com \
--cc=linux-fscrypt@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).