From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 15 Jun 2019 11:21:43 -0400 From: "Theodore Ts'o" Subject: Re: [PATCH v4 13/16] fs-verity: support builtin file signatures Message-ID: <20190615152143.GN6142@mit.edu> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-14-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606155205.2872-14-ebiggers@kernel.org> To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Dave Chinner , Christoph Hellwig , "Darrick J . Wong" , Linus Torvalds List-ID: On Thu, Jun 06, 2019 at 08:52:02AM -0700, Eric Biggers wrote: > From: Eric Biggers > > To meet some users' needs, add optional support for having fs-verity > handle a portion of the authentication policy in the kernel. An > ".fs-verity" keyring is created to which X.509 certificates can be > added; then a sysctl 'fs.verity.require_signatures' can be set to cause > the kernel to enforce that all fs-verity files contain a signature of > their file measurement by a key in this keyring. I think it might be a good idea to allow the require_signatures setting to be set on a per-file system basis, via a mount option? We could plumb it in via a flag in fsverity_info, set by the file system. Other than this feature request, looks good; you can add: Reviewed-off-by: Theodore Ts'o - Ted