From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:41984 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730145AbfIDNim (ORCPT ); Wed, 4 Sep 2019 09:38:42 -0400 Date: Wed, 4 Sep 2019 09:38:36 -0400 From: Mike Snitzer Subject: Re: [PATCH v13 6/6] md: dm-crypt: omit parsing of the encapsulated cipher Message-ID: <20190904133836.GA17836@redhat.com> References: <20190819141738.1231-1-ard.biesheuvel@linaro.org> <20190819141738.1231-7-ard.biesheuvel@linaro.org> <20190903185827.GD13472@redhat.com> <403192f0-d1c4-0c60-5af1-7dee8516d629@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <403192f0-d1c4-0c60-5af1-7dee8516d629@gmail.com> Sender: linux-fscrypt-owner@vger.kernel.org To: Milan Broz Cc: Ard Biesheuvel , linux-crypto@vger.kernel.org, Herbert Xu , Eric Biggers , linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , dm-devel@redhat.com List-ID: On Wed, Sep 04 2019 at 7:01am -0400, Milan Broz wrote: > On 03/09/2019 20:58, Mike Snitzer wrote: > > On Mon, Aug 19 2019 at 10:17am -0400, > > Ard Biesheuvel wrote: > > > >> Only the ESSIV IV generation mode used to use cc->cipher so it could > >> instantiate the bare cipher used to encrypt the IV. However, this is > >> now taken care of by the ESSIV template, and so no users of cc->cipher > >> remain. So remove it altogether. > >> > >> Signed-off-by: Ard Biesheuvel > > > > Acked-by: Mike Snitzer > > > > Might be wise to bump the dm-crypt target's version number (from > > {1, 19, 0} to {1, 20, 0}) at the end of this patch too though... > > The function should be exactly the same, dependencies on needed modules are set. > > In cryptsetup we always report dm target + kernel version, > so we know that since version 5.4 it uses crypto API for ESSIV. > I think version bump here is really not so important. > > Just my two cents :) Yes, that's fine.. I staged it for 5.4 yesterday without the version bump. Thanks, Mike