Re: [PATCH v2] xfs_io/encrypt: support passing a keyring key to add_enckey

Darrick J. Wong
2020-02-20T18:42:15Z

On Tue, Feb 18, 2020 at 01:48:57PM -0800, Eric Biggers wrote:
> On Mon, Feb 03, 2020 at 10:20:13AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Add a '-k' option to the 'add_enckey' xfs_io command to allow exercising
> > the key_id field that is being added to struct fscrypt_add_key_arg.
> >
> > This is needed for the corresponding test in xfstests.
> >
> > For more details, see the corresponding xfstests patches as well as
> > kernel commit 93edd392cad7 ("fscrypt: support passing a keyring key to
> > FS_IOC_ADD_ENCRYPTION_KEY").
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > No changes since v1.
> >
> > This applies to the for-next branch of xfsprogs.
> >
> > configure.ac | 1 +
> > include/builddefs.in | 4 ++
> > io/encrypt.c | 90 +++++++++++++++++++++++++++++++------------
> > m4/package_libcdev.m4 | 21 ++++++++++
> > man/man8/xfs_io.8 | 10 +++--
> > 5 files changed, 98 insertions(+), 28 deletions(-)
> >
>
> Any comments on this patch? The corresponding xfstests patches were merged.

I didn't see any obvious bugs, though fwiw I'm not that familiar with
fscrypt. This looks like a pretty straightforward addition of a new
field to a kernel call structure and some other plumbing to fill out the
new field with CLI arguments / stdin.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> - Eric