Re: [PATCH v2 0/3] fsverity-utils: introduce libfsverity

Eric Biggers
2020-06-06T00:46:56Z

On Fri, Jun 05, 2020 at 12:44:21PM -0400, Jes Sorensen wrote:
> On 5/28/20 9:22 AM, Jes Sorensen wrote:
> > On 5/27/20 5:15 PM, Eric Biggers wrote:
> >> On Mon, May 25, 2020 at 01:54:29PM -0700, Eric Biggers wrote:
> >>> From the 'fsverity' program, split out a library 'libfsverity'.
> >>> Currently it supports computing file measurements ("digests"), and
> >>> signing those file measurements for use with the fs-verity builtin
> >>> signature verification feature.
> >>>
> >>> Rewritten from patches by Jes Sorensen <jsorensen@fb.com>.
> >>> I made a lot of improvements; see patch 2 for details.
> >>>
> >>> This patchset can also be found at branch "libfsverity" of
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/fsverity-utils.git/
> >>>
> >>> Changes v1 => v2:
> >>> - Fold in the Makefile fixes from Jes
> >>> - Rename libfsverity_digest_size() and libfsverity_hash_name()
> >>> - Improve the documentation slightly
> >>> - If a memory allocation fails, print the allocation size
> >>> - Use EBADMSG for invalid cert or keyfile, not EINVAL
> >>> - Make libfsverity_find_hash_alg_by_name() handle NULL
> >>> - Avoid introducing compiler warnings with AOSP's default cflags
> >>> - Don't assume that BIO_new_file() sets errno
> >>> - Other small cleanups
> >>>
> >>> Eric Biggers (3):
> >>> Split up cmd_sign.c
> >>> Introduce libfsverity
> >>> Add some basic test programs for libfsverity
> >>>
> >>
> >> Applied and pushed out to the 'master' branch.
> >
> > Awesome, any idea when you'll be able to tag a new official release?
>
> Hi Eric,
>
> Ping, anything holding up the release at this point?
>
> Sorry for nagging, I would really like to push an updated version to
> Rawhide that can be distributed as a prerequisite for the RPM changes.
>

I might do it this weekend, but I've been working on a test script and some
other improvements first.

Also, please feel free to contribute more test programs or extend the existing
ones. We could use more test coverage of the library.

- Eric