Re: [PATCH v4 4/4] ext4: add inline encryption support

Eric Biggers
2020-07-08T17:34:56Z

On Wed, Jul 08, 2020 at 01:18:12PM -0400, tytso@mit.edu wrote:
> On Thu, Jul 02, 2020 at 01:56:07AM +0000, Satya Tangirala wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > Wire up ext4 to support inline encryption via the helper functions which
> > fs/crypto/ now provides. This includes:
> >
> > - Adding a mount option 'inlinecrypt' which enables inline encryption
> > on encrypted files where it can be used.
> >
> > - Setting the bio_crypt_ctx on bios that will be submitted to an
> > inline-encrypted file.
> >
> > Note: submit_bh_wbc() in fs/buffer.c also needed to be patched for
> > this part, since ext4 sometimes uses ll_rw_block() on file data.
> >
> > - Not adding logically discontiguous data to bios that will be submitted
> > to an inline-encrypted file.
> >
> > - Not doing filesystem-layer crypto on inline-encrypted files.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Co-developed-by: Satya Tangirala <satyat@google.com>
> > Signed-off-by: Satya Tangirala <satyat@google.com>
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
>

Thanks Ted. I've applied this patch to fscrypt.git#master for 5.9.

- Eric