Re: [PATCH v4 0/4] Inline Encryption Support for fscrypt

Eric Biggers
2020-07-07T18:08:57Z

On Thu, Jul 02, 2020 at 01:56:03AM +0000, Satya Tangirala wrote:
> This patch series adds support for Inline Encryption to fscrypt, f2fs
> and ext4. It builds on the inline encryption support now present in
> the block layer, and has been rebased on v5.8-rc3. Note that Patches 1 and
> 2 can be applied independently of Patches 3 and 4 (and Patches 3 and 4 can
> be applied independently of each other).
>
> This patch series previously went though a number of iterations as part
> of the "Inline Encryption Support" patchset (last version was v13:
> https://lkml.kernel.org/r/20200514003727.69001-1-satyat@google.com).
>
> Patch 1 introduces the SB_INLINECRYPT sb options, which filesystems
> should set if they want to use blk-crypto for file content en/decryption.
>
> Patch 2 adds inline encryption support to fscrypt. To use inline
> encryption with fscrypt, the filesystem must set the above mentioned
> SB_INLINECRYPT sb option. When this option is set, the contents of
> encrypted files will be en/decrypted using blk-crypto.
>
> Patches 3 and 4 wire up f2fs and ext4 respectively to fscrypt support for
> inline encryption, and e.g ensure that bios are submitted with blocks
> that not only are contiguous, but also have continuous DUNs.

I've applied patches 1-3 to fscrypt.git#master for 5.9.
Any additional reviews are still appreciated though.

Ted and Andreas, can I get your Acked-by on patch 4?

- Eric