Re: [RFC PATCH v3 03/16] fscrypt: export fscrypt_d_revalidate

Eric Biggers
2020-09-15T00:04:25Z

On Mon, Sep 14, 2020 at 03:16:54PM -0400, Jeff Layton wrote:
> ceph already has its own d_revalidate op so we can't rely on fscrypt
> using that directly. Export this symbol so filesystems can call it
> from their own d_revalidate op.

IMO, a slightly clearer explanation would be:

Since ceph already uses its own dentry_operations, it can't use
fscrypt_d_ops. Instead, export fscrypt_d_revalidate() so that
ceph_d_revalidate() can call it.

Also, it turns out that ext4 and f2fs will need this too. You could add
to the commit message:

This change is also needed by ext4 and f2fs to add support for
directories that are both encrypted and casefolded, since similarly the
current "fscrypt_d_ops" approach is too inflexible for that. See
https://lore.kernel.org/r/20200307023611.204708-6-drosen@google.com and
https://lore.kernel.org/r/20200307023611.204708-8-drosen@google.com.

FYI, I might take this patch for 5.10 to get it out of the way, since
now two patchsets are depending on it.

- Eric