From: Eric Biggers <ebiggers@kernel.org>
To: luca.boccassi@gmail.com
Cc: linux-fscrypt@vger.kernel.org
Subject: Re: [fsverity-utils PATCH] Restore installation of public header via make install
Date: Thu, 29 Oct 2020 08:46:26 -0700 [thread overview]
Message-ID: <20201029154626.GA849@sol.localdomain> (raw)
In-Reply-To: <20201029091828.3680106-1-luca.boccassi@gmail.com>
On Thu, Oct 29, 2020 at 09:18:27AM +0000, luca.boccassi@gmail.com wrote:
> From: Luca Boccassi <luca.boccassi@microsoft.com>
>
> Fixes: 5ca4c55e3382 ("Makefile: generate libfsverity.pc during 'make install'")
>
> Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
> ---
> I think this was removed by mistake? After the linked commit make install
> does not install the header anymore
>
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index a898ed4..bfe83c4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -206,6 +206,7 @@ install:all
> install -m644 libfsverity.a $(DESTDIR)$(LIBDIR)
> install -m755 libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)
> ln -sf libfsverity.so.$(SOVERSION) $(DESTDIR)$(LIBDIR)/libfsverity.so
> + install -m644 include/libfsverity.h $(DESTDIR)$(INCDIR)
> sed -e "s|@PREFIX@|$(PREFIX)|" \
> -e "s|@LIBDIR@|$(LIBDIR)|" \
> -e "s|@INCDIR@|$(INCDIR)|" \
Applied, thanks. Sorry about that.
- Eric
prev parent reply other threads:[~2020-10-29 15:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 9:18 [fsverity-utils PATCH] Restore installation of public header via make install luca.boccassi
2020-10-29 15:46 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029154626.GA849@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox