[PATCH v3 0/5] btrfs: support fsverity

Boris Burkov
2021-04-08T18:33:59Z

This patchset provides support for fsverity in btrfs.

At a high level, we store the verity descriptor and Merkle tree data
in the file system btree with the file's inode as the objectid, and
direct reads/writes to those items to implement the generic fsverity
interface required by fs/verity/.

The first patch is a preparatory patch which adds a notion of
compat_flags to the btrfs_inode and inode_item in order to allow
enabling verity on a file without making the file system unmountable for
older kernels. (It runs afoul of the leaf corruption check otherwise)

The second patch is the bulk of the fsverity implementation. It
implements the fsverity interface and adds verity checks for the typical
file reading case.

The third patch cleans up the corner cases in readpage, covering inline
extents, preallocated extents, and holes.

The fourth patch handles direct io of a veritied file by falling back to
buffered io.

The fifth patch handles crashes mid-verity enable via orphan items

I have tested this patch set in the following ways:
- xfstests auto group
- with a separate fix for btrfs fiemap and some light touches to the
tests themselves: xfstests generic/572,573,574,575.
- new xfstest for btrfs specific corruptions (e.g. inline extents).
- new xfstest using dmlogwrites and dmsnapshot to exercise orphans.
- manual test with pwrite script to test merkle cache EFBIG cases near
the size boundary of my filesystem.
- manual test with sleeps in kernel to force orphan vs. unlink race.
- manual end-to-end test with verity signed rpms.
--
changes for v3:
Patch 2: fix bug in overflow logic, fix interface of
get_verity_descriptor, truncate merkle cache items on failure, fix
various code/style issues.
Patch 5: fix extent data leak if verity races with unlink or O_TMPFILE
and removes a legitimate orphan, then system is interrupted such that
the orphan was needed.

changes for v2:
Patch 1: Unchanged.
Patch 2: Return EFBIG if Merkle data past s_maxbytes. Added special
descriptor item for encryption and to handle ERANGE case for
get_verity_descriptor. Improved function comments. Rebased onto subpage
read patches -- modified end_page_read to do verity check before marking
the page uptodate. Changed from full compat to ro_compat; merged sysfs
feature here.
Patch 3: Rebased onto subpage read patches.
Patch 4: Unchanged.
Patch 5: Used to be sysfs feature, now a new patch that handles orphaned
verity data.

Boris Burkov (4):
btrfs: add compat_flags to btrfs_inode_item
btrfs: check verity for reads of inline extents and holes
btrfs: fallback to buffered io for verity files
btrfs: verity metadata orphan items

Chris Mason (1):
btrfs: initial fsverity support

fs/btrfs/Makefile | 1 +
fs/btrfs/btrfs_inode.h | 2 +
fs/btrfs/ctree.h | 25 +-
fs/btrfs/delayed-inode.c | 2 +
fs/btrfs/extent_io.c | 53 +--
fs/btrfs/file.c | 9 +
fs/btrfs/inode.c | 25 +-
fs/btrfs/ioctl.c | 21 +-
fs/btrfs/super.c | 1 +
fs/btrfs/sysfs.c | 6 +
fs/btrfs/tree-log.c | 1 +
fs/btrfs/verity.c | 683 ++++++++++++++++++++++++++++++++
include/uapi/linux/btrfs.h | 2 +-
include/uapi/linux/btrfs_tree.h | 22 +-
14 files changed, 817 insertions(+), 36 deletions(-)
create mode 100644 fs/btrfs/verity.c

--
2.30.2