From: David Sterba <dsterba@suse.cz>
To: Boris Burkov <boris@bur.io>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-btrfs@vger.kernel.org, linux-fscrypt@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v6 2/3] btrfs: initial fsverity support
Date: Tue, 14 Sep 2021 20:03:53 +0200 [thread overview]
Message-ID: <20210914180353.GI9286@twin.jikos.cz> (raw)
In-Reply-To: <YUDgmgq1Q5l5e/K4@zen>
On Tue, Sep 14, 2021 at 10:49:33AM -0700, Boris Burkov wrote:
> > inode flags ro_compat instead, right?
>
> I believe it is still being used, unless I messed up the patch I sent in
> the end. Taking a quick look, I think it's set at fs/btrfs/verity.c:558.
>
> btrfs_set_fs_compat_ro(root->fs_info, VERITY);
>
> I believe I still needed it because the tree checker doesn't scan every
> inode on the filesystem when you mount, so it would only freak out about
> a ro-compat inode later on if the inode didn't happen to be in a leaf
> that was being checked at mount time.
>
> >
> > 2. Is there a minimum version of btrfs-progs that is required to use btrfs
> > verity? With ext4 and f2fs, the fsck tools had to be updated, so there were
> > minimum versions of the userspace tools required.
>
> Hmm. I didn't update fsck, but now that you mention it, I think I need to...
> I'll test it right away and get back to you, but I suspect I need to
> hurry up and implement it.
The timing of kernel features and btrfs-progs is to have them at the
same release number at the latest, but it could be any time earlier as
it also makes testing easier (released vs git snapshot).
next prev parent reply other threads:[~2021-09-14 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 20:01 [PATCH v6 0/3] btrfs: support fsverity Boris Burkov
2021-06-30 20:01 ` [PATCH v6 1/3] btrfs: add ro compat flags to inodes Boris Burkov
2021-06-30 20:01 ` [PATCH v6 2/3] btrfs: initial fsverity support Boris Burkov
2021-07-11 14:52 ` Eric Biggers
2021-07-28 14:29 ` David Sterba
2021-09-14 18:25 ` Boris Burkov
2021-07-28 15:05 ` David Sterba
2021-09-14 17:32 ` Eric Biggers
2021-09-14 17:49 ` Boris Burkov
2021-09-14 17:56 ` Eric Biggers
2021-09-14 18:34 ` Boris Burkov
2021-09-15 20:45 ` Eric Biggers
2021-09-15 21:01 ` Boris Burkov
2021-09-15 21:12 ` Eric Biggers
2021-09-15 23:14 ` Boris Burkov
2021-09-14 18:03 ` David Sterba [this message]
2021-06-30 20:01 ` [PATCH v6 3/3] btrfs: verity metadata orphan items Boris Burkov
2021-07-28 15:24 ` [PATCH v6 0/3] btrfs: support fsverity David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914180353.GI9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=boris@bur.io \
--cc=ebiggers@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox