Re: [PATCH 02/36] fscrypt: export fscrypt_base64url_encode and fscrypt_base64url_decode

Eric Biggers
2021-12-10T19:10:42Z

On Thu, Dec 09, 2021 at 10:36:13AM -0500, Jeff Layton wrote:
> Ceph is going to add fscrypt support, but we still want encrypted
> filenames to be composed of printable characters, so we can maintain
> compatibility with clients that don't support fscrypt.
>
> We could just adopt fscrypt's current nokey name format, but that is
> subject to change in the future, and it also contains dirhash fields
> that we don't need for cephfs. Because of this, we're going to concoct
> our own scheme for encoding encrypted filenames. It's very similar to
> fscrypt's current scheme, but doesn't bother with the dirhash fields.
>
> The ceph encoding scheme will use base64 encoding as well, and we also
> want it to avoid characters that are illegal in filenames. Export the
> fscrypt base64 encoding/decoding routines so we can use them in ceph's
> fscrypt implementation.
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/crypto/fname.c | 8 ++++----
> include/linux/fscrypt.h | 5 +++++
> 2 files changed, 9 insertions(+), 4 deletions(-)

Acked-by: Eric Biggers <ebiggers@google.com>

- Eric