Re: [PATCH v5 1/2] fscrypt-crypt-util: add HCTR2 implementation

Eric Biggers
2022-08-05T07:41:27Z

On Wed, Aug 03, 2022 at 03:41:20PM -0700, Nathan Huckleberry wrote:
> +static void polyval_update(const u8 key[POLYVAL_KEY_SIZE],
> + const u8 *msg, size_t msglen,
> + u8 accumulator[POLYVAL_BLOCK_SIZE])
> +{
> + ble128 h;
> + ble128 aligned_accumulator;
> + size_t chunk_size;

chunk_size is an unused variable.

Otherwise this looks good:

Reviewed-by: Eric Biggers <ebiggers@google.com>
Tested-by: Eric Biggers <ebiggers@google.com>

- Eric