* [PATCH 0/4] fs: Remove redundant __GFP_NOWARN
@ 2025-08-03 10:22 Qianfeng Rong
2025-08-03 10:22 ` [PATCH 2/4] fscrypto: " Qianfeng Rong
2025-08-14 14:48 ` [PATCH 0/4] fs: " Theodore Ts'o
0 siblings, 2 replies; 4+ messages in thread
From: Qianfeng Rong @ 2025-08-03 10:22 UTC (permalink / raw)
To: Kent Overstreet, Eric Biggers, Theodore Y. Ts'o, Jaegeuk Kim,
Andreas Dilger, Alexander Viro, Christian Brauner, Jan Kara,
open list:BCACHEFS, open list,
open list:FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT,
open list:EXT4 FILE SYSTEM,
open list:FILESYSTEMS (VFS and infrastructure)
Cc: willy, Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
made GFP_NOWAIT implicitly include __GFP_NOWARN.
Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
(e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
up these redundant flags across subsystems.
No functional changes.
Qianfeng Rong (4):
bcachefs: Remove redundant __GFP_NOWARN
fscrypto: Remove redundant __GFP_NOWARN
ext4: Remove redundant __GFP_NOWARN
fs-writeback: Remove redundant __GFP_NOWARN
fs/bcachefs/btree_cache.c | 4 ++--
fs/bcachefs/btree_io.c | 2 +-
fs/bcachefs/btree_iter.h | 6 +++---
fs/bcachefs/btree_trans_commit.c | 2 +-
fs/bcachefs/fs.c | 2 +-
fs/crypto/bio.c | 2 +-
fs/ext4/page-io.c | 2 +-
fs/ext4/super.c | 2 +-
fs/fs-writeback.c | 2 +-
9 files changed, 12 insertions(+), 12 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2/4] fscrypto: Remove redundant __GFP_NOWARN
2025-08-03 10:22 [PATCH 0/4] fs: Remove redundant __GFP_NOWARN Qianfeng Rong
@ 2025-08-03 10:22 ` Qianfeng Rong
2025-08-11 17:31 ` Eric Biggers
2025-08-14 14:48 ` [PATCH 0/4] fs: " Theodore Ts'o
1 sibling, 1 reply; 4+ messages in thread
From: Qianfeng Rong @ 2025-08-03 10:22 UTC (permalink / raw)
To: Eric Biggers, Theodore Y. Ts'o, Jaegeuk Kim,
open list:FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT,
open list
Cc: willy, Qianfeng Rong
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove
the redundant __GFP_NOWARN.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
fs/crypto/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
index 486fcb2ecf13..e92967e20e2a 100644
--- a/fs/crypto/bio.c
+++ b/fs/crypto/bio.c
@@ -148,7 +148,7 @@ int fscrypt_zeroout_range(const struct inode *inode, pgoff_t lblk,
*/
for (i = 0; i < nr_pages; i++) {
pages[i] = fscrypt_alloc_bounce_page(i == 0 ? GFP_NOFS :
- GFP_NOWAIT | __GFP_NOWARN);
+ GFP_NOWAIT);
if (!pages[i])
break;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/4] fscrypto: Remove redundant __GFP_NOWARN
2025-08-03 10:22 ` [PATCH 2/4] fscrypto: " Qianfeng Rong
@ 2025-08-11 17:31 ` Eric Biggers
0 siblings, 0 replies; 4+ messages in thread
From: Eric Biggers @ 2025-08-11 17:31 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Theodore Y. Ts'o, Jaegeuk Kim,
open list:FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT,
open list, willy
On Sun, Aug 03, 2025 at 06:22:40PM +0800, Qianfeng Rong wrote:
> GFP_NOWAIT already includes __GFP_NOWARN, so let's remove
> the redundant __GFP_NOWARN.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> fs/crypto/bio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c
> index 486fcb2ecf13..e92967e20e2a 100644
> --- a/fs/crypto/bio.c
> +++ b/fs/crypto/bio.c
> @@ -148,7 +148,7 @@ int fscrypt_zeroout_range(const struct inode *inode, pgoff_t lblk,
> */
> for (i = 0; i < nr_pages; i++) {
> pages[i] = fscrypt_alloc_bounce_page(i == 0 ? GFP_NOFS :
> - GFP_NOWAIT | __GFP_NOWARN);
> + GFP_NOWAIT);
> if (!pages[i])
> break;
> }
> --
> 2.34.1
>
Applied to https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next
Thanks!
- Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/4] fs: Remove redundant __GFP_NOWARN
2025-08-03 10:22 [PATCH 0/4] fs: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-03 10:22 ` [PATCH 2/4] fscrypto: " Qianfeng Rong
@ 2025-08-14 14:48 ` Theodore Ts'o
1 sibling, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2025-08-14 14:48 UTC (permalink / raw)
To: Ext4 Developers List, Kent Overstreet, Eric Biggers, Jaegeuk Kim,
Andreas Dilger, Alexander Viro, Christian Brauner, Jan Kara,
linux-bcachefs, linux-kernel, linux-fscrypt, linux-fsdevel,
Qianfeng Rong
Cc: Theodore Ts'o, willy
On Sun, 03 Aug 2025 18:22:38 +0800, Qianfeng Rong wrote:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT")
> made GFP_NOWAIT implicitly include __GFP_NOWARN.
>
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT
> (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean
> up these redundant flags across subsystems.
>
> [...]
Applied, thanks!
[3/4] ext4: Remove redundant __GFP_NOWARN
commit: 4ba97589ed19210ff808929052696f5636139823
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-14 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-03 10:22 [PATCH 0/4] fs: Remove redundant __GFP_NOWARN Qianfeng Rong
2025-08-03 10:22 ` [PATCH 2/4] fscrypto: " Qianfeng Rong
2025-08-11 17:31 ` Eric Biggers
2025-08-14 14:48 ` [PATCH 0/4] fs: " Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox