From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 113872C21CB; Mon, 11 Aug 2025 17:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754933525; cv=none; b=CQz1es5xC4W0vYr1kcAxHR5HP4PEzzl3r1P4SYiHKwJh/6dNydvf+z8Warhx6BaECwH15XFgfdSuji9GpCI8wr7CusfoceEgPY7B62U/I/tBBAwNL124wm4Yjrr83SjlljRUBsKRuIbpemkV3VgDB2HHcgQgK3hgadJkwd2pPUQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754933525; c=relaxed/simple; bh=3SXwtl2OtaQFXcCQM1wIwDc4Vz/l1VygIiHIWJrC0bI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KNaPQx4Ug3oU4WOEzpFqfJl0oF9bPXyo5b54TWa1v6HNKqlnFw1uyzpG+MukLYAo6+mwbzkJicP/feWT5YwcchCzGGl7/AUOhlq7RGzBmigiA+zIqgMOvx2YLvD4+jFi1V6prPBVLYuwkrlVaZ9jn3Qtewn7+jzy01wLU4WLpmc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RqJYdiQR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RqJYdiQR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 667EDC4CEF4; Mon, 11 Aug 2025 17:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754933524; bh=3SXwtl2OtaQFXcCQM1wIwDc4Vz/l1VygIiHIWJrC0bI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RqJYdiQRFtKoGiCNGtK4TOcFiHp0KRS4YArjbK/swfNhsg43KcF1AF/hL+KlrTa4W XBHwqdCN77C2VwTbU5ygOGQDQJnAdAvzS3usxsjXuS5VeaARKSQxUgESIV+MnyVRwZ uSwlZYSYvLDBKn0JnfDA1rN4xY5gKlXbkn42s6uf18xEXNSmvdUIZDvYySEfL1Lr88 YFrm4mok/PzO6PC6E1UOwUaQEcdRzKFZ599YmwaNYjyhnmywyCOom7BAu8a+RgLK9Q FFmNx+E8767CcEIgNhholxL0xlqAw6LCJ0nvvCd1f/HXskL3GIuFFLMJoJdLKDeH3j G3YxOH5M6wAKA== Date: Mon, 11 Aug 2025 10:31:03 -0700 From: Eric Biggers To: Qianfeng Rong Cc: "Theodore Y. Ts'o" , Jaegeuk Kim , "open list:FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT" , open list , willy@infradead.org Subject: Re: [PATCH 2/4] fscrypto: Remove redundant __GFP_NOWARN Message-ID: <20250811173103.GC1268@sol> References: <20250803102243.623705-1-rongqianfeng@vivo.com> <20250803102243.623705-3-rongqianfeng@vivo.com> Precedence: bulk X-Mailing-List: linux-fscrypt@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250803102243.623705-3-rongqianfeng@vivo.com> On Sun, Aug 03, 2025 at 06:22:40PM +0800, Qianfeng Rong wrote: > GFP_NOWAIT already includes __GFP_NOWARN, so let's remove > the redundant __GFP_NOWARN. > > Signed-off-by: Qianfeng Rong > --- > fs/crypto/bio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/crypto/bio.c b/fs/crypto/bio.c > index 486fcb2ecf13..e92967e20e2a 100644 > --- a/fs/crypto/bio.c > +++ b/fs/crypto/bio.c > @@ -148,7 +148,7 @@ int fscrypt_zeroout_range(const struct inode *inode, pgoff_t lblk, > */ > for (i = 0; i < nr_pages; i++) { > pages[i] = fscrypt_alloc_bounce_page(i == 0 ? GFP_NOFS : > - GFP_NOWAIT | __GFP_NOWARN); > + GFP_NOWAIT); > if (!pages[i]) > break; > } > -- > 2.34.1 > Applied to https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next Thanks! - Eric