Re: [PATCH 9/9] blk-crypto: use mempool_alloc_bulk for encrypted bio page allocation

Christoph Hellwig
2025-11-06T14:01:50Z

On Wed, Nov 05, 2025 at 04:12:29PM +0100, Vlastimil Babka wrote:
> > + memset(pages, 0, sizeof(struct page *) * nr_segs);
> > + if (alloc_pages_bulk(GFP_NOFS, nr_segs, pages) < nr_segs) {
> > + mempool_alloc_bulk(blk_crypto_bounce_page_pool, (void **)pages,
> > + nr_segs, GFP_NOIO);
>
> Why do the GFP flags differ?

Me messing up. So fsr all blk-crypto stuff was GFP_NOIO. I think it
generally should be GFP_NOFS now, but f2fs is doing some weird things
with GFP_NOIO. (Could everyone please document their restrictions,
preferable using the task flags, thanks..).

I'll restore GFP_NOIO for the next version.