Re: [PATCH v5 3/6] lib/base64: rework encode/decode for speed and stricter validation

Andy Shevchenko
2025-11-18T10:38:51Z

On Mon, Nov 17, 2025 at 09:46:52AM -0800, Andrew Morton wrote:
> On Sun, 16 Nov 2025 18:28:49 +0800 Guan-Chun Wu <409411716@gms.tku.edu.tw> wrote:
>
> > > Reviewed-by: David Laight <david.laight.linux@gmail.com>
> > >
> > > But see minor nit below.
> >
> > Hi David,
> >
> > Thanks for the review and for pointing this out.
> >
> > Andrew, would it be possible for you to fold this small change
> > (removing the redundant casts) directly when updating the patch?
> > If that’s not convenient, I can resend an updated version of the
> > series instead.
>
> Sure, I added this:

The file also needs to fix the kernel-doc

$ scripts/kernel-doc -none -v -Wall lib/base64.c
Warning: lib/base64.c:24 This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Initialize the base64 reverse mapping for a single character
Warning: lib/base64.c:36 This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Recursive macros to generate multiple Base64 reverse mapping table entries.
Info: lib/base64.c:67 Scanning doc for function base64_encode
Info: lib/base64.c:119 Scanning doc for function base64_decode

--
With Best Regards,
Andy Shevchenko