Re: [RFC PATCH v3 04/16] fscrypt: add fscrypt_context_for_new_inode

Eric Biggers
2020-09-15T00:15:32Z

On Mon, Sep 14, 2020 at 03:16:55PM -0400, Jeff Layton wrote:
> /*
> * This may be the first time the inode number is available, so do any
> @@ -689,7 +711,6 @@ int fscrypt_set_context(struct inode *inode, void *fs_data)
>
> fscrypt_hash_inode_number(ci, mk);
> }
> -
> return inode->i_sb->s_cop->set_context(inode, &ctx, ctxsize, fs_data);

Unnecessary whitespace change.

> diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h
> index b547e1aabb00..a57d2a9869eb 100644
> --- a/include/linux/fscrypt.h
> +++ b/include/linux/fscrypt.h
> @@ -148,6 +148,7 @@ int fscrypt_ioctl_get_policy_ex(struct file *filp, void __user *arg);
> int fscrypt_ioctl_get_nonce(struct file *filp, void __user *arg);
> int fscrypt_has_permitted_context(struct inode *parent, struct inode *child);
> int fscrypt_set_context(struct inode *inode, void *fs_data);
> +int fscrypt_context_for_new_inode(void *ctx, struct inode *inode);

Please keep declarations in the same order as the definitions.
So, fscrypt_context_for_new_inode() before fscrypt_set_context().

- Eric