From: Luca Boccassi <Luca.Boccassi@microsoft.com>
To: "ebiggers@kernel.org" <ebiggers@kernel.org>,
"linux-fscrypt@vger.kernel.org" <linux-fscrypt@vger.kernel.org>
Cc: "Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>
Subject: Re: [fsverity-utils PATCH 2/2] programs/fsverity: share code to parse tree parameters
Date: Mon, 16 Nov 2020 11:32:47 +0000 [thread overview]
Message-ID: <7dfd108175a3d0a2403366e272da221c549f1a96.camel@microsoft.com> (raw)
In-Reply-To: <20201114001529.185751-3-ebiggers@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Fri, 2020-11-13 at 16:15 -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> The "digest", "enable", and "sign" commands all parse the --hash-alg,
> --block-size, and --salt options and initialize a struct
> libfsverity_merkle_tree_params, so share the code that does this.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> programs/cmd_digest.c | 31 ++++---------------------------
> programs/cmd_enable.c | 30 ++++--------------------------
> programs/cmd_sign.c | 31 ++++---------------------------
> programs/fsverity.c | 42 ++++++++++++++++++++++++++++++++++++++----
> programs/fsverity.h | 19 +++++++++++++++----
> 5 files changed, 65 insertions(+), 88 deletions(-)
Acked-by: Luca Boccassi <luca.boccassi@microsoft.com>
--
Kind regards,
Luca Boccassi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-11-16 12:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:15 [fsverity-utils PATCH 0/2] Add libfsverity_enable() API Eric Biggers
2020-11-14 0:15 ` [fsverity-utils PATCH 1/2] lib: add libfsverity_enable() and libfsverity_enable_with_sig() Eric Biggers
2020-11-16 11:52 ` Luca Boccassi
2020-11-16 17:41 ` Eric Biggers
2020-11-16 17:50 ` Luca Boccassi
2020-11-16 18:42 ` Eric Biggers
2020-11-16 19:28 ` Luca Boccassi
2020-11-14 0:15 ` [fsverity-utils PATCH 2/2] programs/fsverity: share code to parse tree parameters Eric Biggers
2020-11-16 11:32 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dfd108175a3d0a2403366e272da221c549f1a96.camel@microsoft.com \
--to=luca.boccassi@microsoft.com \
--cc=Jes.Sorensen@gmail.com \
--cc=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox