From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Chao Yu Subject: [f2fs-dev] [PATCH v7 14/16] f2fs: wire up new fscrypt ioctls References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-15-ebiggers@kernel.org> <20190802173148.GA51937@gmail.com> Message-ID: <88479efb-6625-8778-f802-e159ec60a374@kernel.org> Date: Sun, 4 Aug 2019 17:42:11 +0800 MIME-Version: 1.0 In-Reply-To: <20190802173148.GA51937@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: keyrings-owner@vger.kernel.org To: Chao Yu , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala List-ID: On 2019-8-3 1:31, Eric Biggers wrote: > On Fri, Aug 02, 2019 at 04:10:15PM +0800, Chao Yu wrote: >> Hi Eric, >> >> On 2019/7/27 6:41, Eric Biggers wrote: >>> From: Eric Biggers >>> >>> Wire up the new ioctls for adding and removing fscrypt keys to/from the >>> filesystem, and the new ioctl for retrieving v2 encryption policies. >>> >>> FS_IOC_REMOVE_ENCRYPTION_KEY also required making f2fs_drop_inode() call >>> fscrypt_drop_inode(). >>> >>> For more details see Documentation/filesystems/fscrypt.rst and the >>> fscrypt patches that added the implementation of these ioctls. >>> >>> Signed-off-by: Eric Biggers >> >> Reviewed-by: Chao Yu >> >> BTW, do you think it needs to make xxfs_has_support_encrypt() function be a >> common interface defined in struct fscrypt_operations, as I see all >> fscrypt_ioctl_*() needs to check with it, tho such cleanup is minor... >> > > Maybe. It would work nicely for ext4 and f2fs, but ubifs does things > differently since it automatically enables the encryption feature if needed. > So we'd have to make the callback optional. Correct, ubifs can leave the callback as NULL function pointer. > > In any case, I think this should be separate from this patchset. Yup, it can be done in a separated patch if need. Thanks, > > - Eric > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >