From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fscrypt-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B0A4AC433DB
	for <linux-fscrypt@archiver.kernel.org>; Mon,  4 Jan 2021 03:46:45 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8B84B20E65
	for <linux-fscrypt@archiver.kernel.org>; Mon,  4 Jan 2021 03:46:45 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727091AbhADDqa (ORCPT
        <rfc822;linux-fscrypt@archiver.kernel.org>);
        Sun, 3 Jan 2021 22:46:30 -0500
Received: from mail.kernel.org ([198.145.29.99]:34608 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727037AbhADDq1 (ORCPT <rfc822;linux-fscrypt@vger.kernel.org>);
        Sun, 3 Jan 2021 22:46:27 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 961562087E;
        Mon,  4 Jan 2021 03:45:46 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1609731946;
        bh=6ARBT7fFQGUTWuwnrfa5PJ/9w9tyLns+HdyLR3NXCPI=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=YZC1dXHL+EmCdKCQ4V/QzikM849gh3LL7x0oeyt/hBrM2tgOOQc7UGu9R/BM0Bw/h
         xfw3l6gG2s4ezllPRVVAYDuK+wfI4OsrsklFYVD76PuQdU/KgoH4PP2n9M68itaJqf
         RyLA2uRT8qxqBMb6Up8KzEdZ2i6opg/f1Cp/PjyfhJAp14Zyjj7mJwkaPq6uHTwnvd
         16v5fTnexkktHb/lJGLsISrBZqbag5G9tSEV430b5OlEJ5d9MYgx/YdhdGuTXWRR8W
         ePSdgSdhoLhHRHxNMRGQ+j4Jm1DQe6wv82vMPu34OLhgYybXwZQMDw9uIYdTdKCRQT
         eN/E7LYVMc/MA==
Date:   Sun, 3 Jan 2021 19:45:45 -0800
From:   Eric Biggers <ebiggers@kernel.org>
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-fscrypt@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: clean up post-read processing
Message-ID: <X/KPaX7Z0WDEXhBM@sol.localdomain>
References: <20201228232612.45538-1-ebiggers@kernel.org>
 <a43158eb-114e-7f7f-871a-7bd9c70639d6@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a43158eb-114e-7f7f-871a-7bd9c70639d6@huawei.com>
Precedence: bulk
List-ID: <linux-fscrypt.vger.kernel.org>
X-Mailing-List: linux-fscrypt@vger.kernel.org

On Mon, Jan 04, 2021 at 11:35:58AM +0800, Chao Yu wrote:
> On 2020/12/29 7:26, Eric Biggers wrote:
> > +	if (ctx && (ctx->enabled_steps & (STEP_DECRYPT | STEP_DECOMPRESS))) {
> > +		INIT_WORK(&ctx->work, f2fs_post_read_work);
> > +		queue_work(ctx->sbi->post_read_wq, &ctx->work);
> 
> Could you keep STEP_DECOMPRESS_NOWQ related logic? so that bio only includes
> non-compressed pages could be handled in irq context rather than in wq context
> which should be unneeded.
> 
> Thanks,
> 

That's already handled; I made it so that STEP_DECOMPRESS is only enabled when
it's actually needed.

- Eric