Re: [PATCH v5 2/8] vfs: support STATX_DIOALIGN on block devices

Christian Brauner
2022-09-07T09:09:14Z

On Fri, Aug 26, 2022 at 11:58:45PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Add support for STATX_DIOALIGN to block devices, so that direct I/O
> alignment restrictions are exposed to userspace in a generic way.
>
> Note that this breaks the tradition of stat operating only on the block
> device node, not the block device itself. However, it was felt that
> doing this is preferable, in order to make the interface useful and
> avoid needing separate interfaces for regular files and block devices.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---

Looks good to me,
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>