From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Mike Snitzer <snitzer@kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces
Date: Fri, 4 Nov 2022 00:28:13 -0700 [thread overview]
Message-ID: <Y2S/DfZTr90t6QXv@sol.localdomain> (raw)
In-Reply-To: <20221104054621.628369-2-hch@lst.de>
On Fri, Nov 04, 2022 at 06:46:20AM +0100, Christoph Hellwig wrote:
> Each device driver that
> wants to support inline encryption will construct a blk_crypto_profile, then
> -associate it with the disk's request_queue.
> +associate it with the block device.
>
[...]
> -Once the driver registers a blk_crypto_profile with a request_queue, I/O
> +Once the driver registers a blk_crypto_profile with a block_device, I/O
> requests the driver receives via that queue may have an encryption context.
[...]
> -Request queue based layered devices like dm-rq that wish to support inline
> -encryption need to create their own blk_crypto_profile for their request_queue,
> +Request based layered devices like dm-rq that wish to support inline
> +encryption need to create their own blk_crypto_profile for their block_device,
> and expose whatever functionality they choose. When a layered device wants to
[...]
Shouldn't the three places above still say request_queue, not block_device?
They're talking about the driver.
- Eric
next prev parent reply other threads:[~2022-11-04 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 5:46 pass a struct block_device to the blk-crypto interfaces Christoph Hellwig
2022-11-04 5:46 ` [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces Christoph Hellwig
2022-11-04 7:28 ` Eric Biggers [this message]
2022-11-04 7:32 ` Christoph Hellwig
2022-11-04 5:46 ` [PATCH 2/2] blk-crypto: add a blk_crypto_cfg_supported helper Christoph Hellwig
2022-11-04 7:23 ` Eric Biggers
2022-11-04 7:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2S/DfZTr90t6QXv@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox