From: Eric Biggers <ebiggers@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] fscrypt: support decrypting data from large folios
Date: Fri, 27 Jan 2023 15:41:23 -0800 [thread overview]
Message-ID: <Y9RhIwSzUE0/tbo/@sol.localdomain> (raw)
In-Reply-To: <Y9RfZaGoQ07UkD6w@casper.infradead.org>
On Fri, Jan 27, 2023 at 11:33:57PM +0000, Matthew Wilcox wrote:
> On Fri, Jan 27, 2023 at 02:42:02PM -0800, Eric Biggers wrote:
> > +++ b/fs/buffer.c
> > @@ -307,8 +307,8 @@ static void decrypt_bh(struct work_struct *work)
> > struct buffer_head *bh = ctx->bh;
> > int err;
> >
> > - err = fscrypt_decrypt_pagecache_blocks(bh->b_page, bh->b_size,
> > - bh_offset(bh));
> > + err = fscrypt_decrypt_pagecache_blocks(page_folio(bh->b_page),
> > + bh->b_size, bh_offset(bh));
>
> FYI, Andrew's been carrying "buffer: add b_folio as an alias of b_page"
> in his tree since mid-December. buffer_heads always point to the
> head page, aka folio.
>
> This all looks good to me.
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Indeed, but it's not upstream yet, so I decided to use page_folio() for now to
avoid a cross-tree dependency.
- Eric
next prev parent reply other threads:[~2023-01-27 23:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 22:42 [PATCH] fscrypt: support decrypting data from large folios Eric Biggers
2023-01-27 23:33 ` Matthew Wilcox
2023-01-27 23:41 ` Eric Biggers [this message]
2023-02-03 21:57 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9RhIwSzUE0/tbo/@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox