From: Eric Biggers <ebiggers@kernel.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Stefan Berger <stefanb@linux.ibm.com>,
linux-fscrypt@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/8] fs-verity: define a function to return the integrity protected file digest
Date: Mon, 31 Jan 2022 16:44:35 -0800 [thread overview]
Message-ID: <YfiCc9XXzbQz9rqy@sol.localdomain> (raw)
In-Reply-To: <20220126000658.138345-4-zohar@linux.ibm.com>
On Tue, Jan 25, 2022 at 07:06:53PM -0500, Mimi Zohar wrote:
> + hash_alg = vi->tree_params.hash_alg;
> + memset(digest, 0, FS_VERITY_MAX_DIGEST_SIZE);
> +
> + /* convert hash algorithm to hash_algo_name */
> + i = match_string(hash_algo_name, HASH_ALGO__LAST, hash_alg->name);
> + if (i < 0)
> + return -EINVAL;
> + *alg = i;
The above comment is backwards. This code is converting a hash algorithm name
to an ID. The comment is unclear, but it sounds like it's saying the opposite.
> +
> + memcpy(digest, vi->file_digest, hash_alg->digest_size);
Here there are two "sources of truth" for the digest size. How about checking
that they are the same:
if (WARN_ON_ONCE(hash_alg->digest_size != hash_digest_size[*alg]))
return -EINVAL;
- Eric
next prev parent reply other threads:[~2022-02-01 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 0:06 [PATCH v3 0/8] ima: support fs-verity digests and signatures Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 1/8] ima: rename IMA_ACTION_FLAGS to IMA_NONACTION_FLAGS Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 2/8] ima: define ima_max_digest_data struct without a flexible array variable Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 3/8] fs-verity: define a function to return the integrity protected file digest Mimi Zohar
2022-02-01 0:44 ` Eric Biggers [this message]
2022-01-26 0:06 ` [PATCH v3 4/8] ima: define a new template field 'd-type' and a new template 'ima-ngv2' Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 5/8] ima: include fsverity's file digests in the IMA measurement list Mimi Zohar
2022-02-01 0:56 ` Eric Biggers
2022-01-26 0:06 ` [PATCH v3 6/8] ima: define signature version 3 Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 7/8] ima: support fs-verity file digest based version 3 signatures Mimi Zohar
2022-02-01 1:06 ` Eric Biggers
2022-02-01 17:03 ` Mimi Zohar
2022-01-26 0:06 ` [PATCH v3 8/8] fsverity: update the documentation Mimi Zohar
2022-02-01 0:36 ` [PATCH v3 0/8] ima: support fs-verity digests and signatures Eric Biggers
2022-02-01 19:20 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfiCc9XXzbQz9rqy@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox