Re: [PATCH v3 1/5] ext4: fix memory leak in parse_apply_sb_mount_options()

Theodore Ts'o
2022-05-19T02:11:04Z

On Fri, May 13, 2022 at 04:16:01PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> If processing the on-disk mount options fails after any memory was
> allocated in the ext4_fs_context, e.g. s_qf_names, then this memory is
> leaked. Fix this by calling ext4_fc_free() instead of kfree() directly.
>
> Reproducer:
>
> mkfs.ext4 -F /dev/vdc
> tune2fs /dev/vdc -E mount_opts=usrjquota=file
> echo clear > /sys/kernel/debug/kmemleak
> mount /dev/vdc /vdc
> echo scan > /sys/kernel/debug/kmemleak
> sleep 5
> echo scan > /sys/kernel/debug/kmemleak
> cat /sys/kernel/debug/kmemleak
>
> Fixes: 7edfd85b1ffd ("ext4: Completely separate options parsing and sb setup")
> Cc: stable@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

- Ted