Re: [PATCH v13 2/5] common/verity: support btrfs in generic fsverity tests

[Eric Biggers <ebiggers@kernel.org>]

On Tue, Jul 19, 2022 at 05:49:47PM -0700, Boris Burkov wrote:
> generic/572-579 have tests for fsverity. Now that btrfs supports
> fsverity, make these tests function as well. For a majority of the tests
> that pass, simply adding the case to mkfs a btrfs filesystem with no
> extra options is sufficient.
> 
> However, generic/574 has tests for corrupting the merkle tree itself.
> Since btrfs uses a different scheme from ext4 and f2fs for storing this
> data, the existing logic for corrupting it doesn't work out of the box.
> Adapt it to properly corrupt btrfs merkle items.
> 
> 576 does not run because btrfs does not support transparent encryption.
> 
> This test relies on the btrfs implementation of fsverity in the patch:
> btrfs: initial fsverity support
> 
> and on btrfs-corrupt-block for corruption in the patches titled:
> btrfs-progs: corrupt generic item data with btrfs-corrupt-block
> btrfs-progs: expand corrupt_file_extent in btrfs-corrupt-block
> 
> Signed-off-by: Boris Burkov <boris@bur.io>
> Reviewed-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
> ---
>  common/btrfs          |  5 +++++
>  common/config         |  1 +
>  common/verity         | 31 +++++++++++++++++++++++++++++++
>  tests/generic/574     | 37 ++++++++++++++++++++++++++++++++++---
>  tests/generic/574.out | 13 ++++---------
>  5 files changed, 75 insertions(+), 12 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric