From: Eric Biggers <ebiggers@kernel.org>
To: Nathan Huckleberry <nhuck@google.com>
Cc: fstests@vger.kernel.org, linux-fscrypt@vger.kernel.org,
Sami Tolvanen <samitolvanen@google.com>
Subject: Re: [PATCH v5 1/2] fscrypt-crypt-util: add HCTR2 implementation
Date: Fri, 5 Aug 2022 00:40:58 -0700 [thread overview]
Message-ID: <YuzJild58hvljFRY@sol.localdomain> (raw)
In-Reply-To: <20220803224121.420705-2-nhuck@google.com>
On Wed, Aug 03, 2022 at 03:41:20PM -0700, Nathan Huckleberry wrote:
> +static void polyval_update(const u8 key[POLYVAL_KEY_SIZE],
> + const u8 *msg, size_t msglen,
> + u8 accumulator[POLYVAL_BLOCK_SIZE])
> +{
> + ble128 h;
> + ble128 aligned_accumulator;
> + size_t chunk_size;
chunk_size is an unused variable.
Otherwise this looks good:
Reviewed-by: Eric Biggers <ebiggers@google.com>
Tested-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2022-08-05 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 22:41 [PATCH v5 0/2] generic: test HCTR2 filename encryption Nathan Huckleberry
2022-08-03 22:41 ` [PATCH v5 1/2] fscrypt-crypt-util: add HCTR2 implementation Nathan Huckleberry
2022-08-05 7:40 ` Eric Biggers [this message]
2022-08-03 22:41 ` [PATCH v5 2/2] generic: add tests for fscrypt policies with HCTR2 Nathan Huckleberry
2022-08-05 7:41 ` Eric Biggers
2022-08-03 22:42 ` [PATCH v5 0/2] generic: test HCTR2 filename encryption Nathan Huckleberry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuzJild58hvljFRY@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=nhuck@google.com \
--cc=samitolvanen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox