Re: [PATCH v4] btrfs: send: add support for fs-verity

Eric Biggers
2022-08-18T17:51:56Z

On Thu, Aug 18, 2022 at 07:40:10PM +0200, David Sterba wrote:
> On Wed, Aug 17, 2022 at 09:57:22PM -0700, Eric Biggers wrote:
> > On Mon, Aug 15, 2022 at 01:54:28PM -0700, Boris Burkov wrote:
> > > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > > index e7671afcee4f..9e8679848d54 100644
> > > --- a/fs/btrfs/send.c
> > > +++ b/fs/btrfs/send.c
> > > @@ -3,6 +3,7 @@
> > > * Copyright (C) 2012 Alexander Block. All rights reserved.
> > > */
> > >
> > > +#include "linux/compiler_attributes.h"
> >
> > I don't understand the purpose of this include. And why is it in quotes?
>
> It compiles without it so I've deleted it.
>
> >
> > Otherwise this patch looks good to me.
>
> I assume it's acked-by/reviewed-by namely for the fs-verity changes,
> right?

Yes if you're just fixing that without a new version, you can add:

Acked-by: Eric Biggers <ebiggers@google.com>

(By the way, please fix your email client to not generate a Mail-Followup-To
header, as it causes replies to move everyone to "To". If you're using mutt,
you need 'set followup_to = no' in your muttrc.)

- Eric