From: Boris Burkov <boris@bur.io>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH v4] btrfs: send: add support for fs-verity
Date: Thu, 18 Aug 2022 11:29:57 -0700 [thread overview]
Message-ID: <Yv6FJf5Kf1dskUcz@zen> (raw)
In-Reply-To: <Yv3GssrE8hAFzGLJ@sol.localdomain>
On Wed, Aug 17, 2022 at 09:57:22PM -0700, Eric Biggers wrote:
> On Mon, Aug 15, 2022 at 01:54:28PM -0700, Boris Burkov wrote:
> > diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> > index e7671afcee4f..9e8679848d54 100644
> > --- a/fs/btrfs/send.c
> > +++ b/fs/btrfs/send.c
> > @@ -3,6 +3,7 @@
> > * Copyright (C) 2012 Alexander Block. All rights reserved.
> > */
> >
> > +#include "linux/compiler_attributes.h"
>
> I don't understand the purpose of this include. And why is it in quotes?
Sorry about that. I have this weird feeling that vim-lsp is "helpfully"
adding includes for me sometimes. I'll look out for it next time I send
a patch.
Thanks for the review.
>
> Otherwise this patch looks good to me.
>
> - Eric
next prev parent reply other threads:[~2022-08-18 18:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 20:54 [PATCH v4] btrfs: send: add support for fs-verity Boris Burkov
2022-08-16 9:09 ` kernel test robot
2022-08-18 4:57 ` Eric Biggers
2022-08-18 17:40 ` David Sterba
2022-08-18 17:51 ` Eric Biggers
2022-08-18 18:29 ` Boris Burkov [this message]
2022-08-18 17:32 ` David Sterba
2022-08-18 18:49 ` Boris Burkov
2022-08-22 12:50 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv6FJf5Kf1dskUcz@zen \
--to=boris@bur.io \
--cc=ebiggers@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox